Commit b5ce150
Queue::fake six V2RunDetailViewTest tests + available_at-aware drain
Six RunDetailView tests were racing real testbench queue workers in CI
under the same bucket A pattern as the V2WorkflowTest conversions in
d042ea9 / 561a441. They pass reliably on local docker but time out at
5–30s on contention-bound GitHub Actions runners.
Convert them to the Queue::fake + drainReadyTasks pattern so they are
self-contained, and teach V2RunDetailViewTest's local drainReadyTasks
helper to respect `available_at` just like the real worker does (same
patch shape as d042ea9 on V2WorkflowTest). Without the available_at
filter, drainReadyTasks would fire future-scheduled timer tasks early
and the test would observe a completed workflow when it expected a
parked one.
Clears 6 CI-only MySQL failures under #399:
* testRunDetailViewIncludesCommandsActivitiesAndTimelineForCompletedSignalRun
* testRunDetailViewKeepsActivityDetailWhenActivityRowDrifts
* testRunDetailViewFallsBackToTypedActivityHistoryWhenActivityRowIsMissing
* testRunDetailViewKeepsSignalWaitCommandMetadataWhenCommandRowsDrift
* testRunDetailViewIncludesChildWaitAndLineageForParentRun
* testRunDetailViewReturnsTypedPayloadsNotPhpSerializedStrings
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 561a441 commit b5ce150
1 file changed
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1094 | 1094 | | |
1095 | 1095 | | |
1096 | 1096 | | |
| 1097 | + | |
| 1098 | + | |
1097 | 1099 | | |
1098 | 1100 | | |
1099 | 1101 | | |
1100 | 1102 | | |
1101 | 1103 | | |
1102 | 1104 | | |
| 1105 | + | |
1103 | 1106 | | |
1104 | 1107 | | |
1105 | 1108 | | |
1106 | 1109 | | |
| 1110 | + | |
1107 | 1111 | | |
1108 | 1112 | | |
1109 | 1113 | | |
| |||
1203 | 1207 | | |
1204 | 1208 | | |
1205 | 1209 | | |
| 1210 | + | |
| 1211 | + | |
1206 | 1212 | | |
1207 | 1213 | | |
1208 | 1214 | | |
1209 | 1215 | | |
1210 | 1216 | | |
1211 | 1217 | | |
| 1218 | + | |
1212 | 1219 | | |
1213 | 1220 | | |
1214 | 1221 | | |
1215 | 1222 | | |
| 1223 | + | |
1216 | 1224 | | |
1217 | 1225 | | |
1218 | 1226 | | |
| |||
1250 | 1258 | | |
1251 | 1259 | | |
1252 | 1260 | | |
| 1261 | + | |
| 1262 | + | |
1253 | 1263 | | |
1254 | 1264 | | |
1255 | 1265 | | |
1256 | 1266 | | |
1257 | 1267 | | |
1258 | 1268 | | |
| 1269 | + | |
1259 | 1270 | | |
1260 | 1271 | | |
1261 | 1272 | | |
1262 | 1273 | | |
| 1274 | + | |
1263 | 1275 | | |
1264 | 1276 | | |
1265 | 1277 | | |
| |||
1291 | 1303 | | |
1292 | 1304 | | |
1293 | 1305 | | |
| 1306 | + | |
| 1307 | + | |
1294 | 1308 | | |
1295 | 1309 | | |
1296 | 1310 | | |
1297 | 1311 | | |
1298 | 1312 | | |
1299 | 1313 | | |
| 1314 | + | |
1300 | 1315 | | |
1301 | 1316 | | |
1302 | 1317 | | |
1303 | 1318 | | |
| 1319 | + | |
1304 | 1320 | | |
1305 | 1321 | | |
1306 | 1322 | | |
| |||
2269 | 2285 | | |
2270 | 2286 | | |
2271 | 2287 | | |
| 2288 | + | |
| 2289 | + | |
2272 | 2290 | | |
2273 | 2291 | | |
2274 | 2292 | | |
2275 | 2293 | | |
2276 | 2294 | | |
2277 | 2295 | | |
| 2296 | + | |
2278 | 2297 | | |
2279 | 2298 | | |
2280 | 2299 | | |
| |||
3713 | 3732 | | |
3714 | 3733 | | |
3715 | 3734 | | |
| 3735 | + | |
| 3736 | + | |
3716 | 3737 | | |
3717 | 3738 | | |
3718 | 3739 | | |
| 3740 | + | |
3719 | 3741 | | |
3720 | 3742 | | |
3721 | 3743 | | |
3722 | 3744 | | |
| 3745 | + | |
3723 | 3746 | | |
3724 | 3747 | | |
3725 | 3748 | | |
| |||
3803 | 3826 | | |
3804 | 3827 | | |
3805 | 3828 | | |
| 3829 | + | |
| 3830 | + | |
| 3831 | + | |
| 3832 | + | |
3806 | 3833 | | |
3807 | 3834 | | |
3808 | 3835 | | |
| |||
0 commit comments