Merge pull request #389 from durable-workflow/fix/replay-preserve-structured-failure

Preserve structured replay failures for standalone workers

Author: rmcdaniel

src/V2/Support/FailureFactory.php

@@ -249,6 +249,15 @@ public static function restoreForReplay(
         ?int $fallbackCode = null,
     ): Throwable {
         $normalized = self::normalizePayload($payload, $fallbackClass, $fallbackMessage, $fallbackCode);
+
+        if (
+            array_key_exists('details', $normalized)
+            || is_string($normalized['details_payload_codec'] ?? null)
+            || array_key_exists('non_retryable', $normalized)
+        ) {
+            return new RestoredWorkflowException($normalized);
+        }
+
         $class = $normalized['class'];
 
         try {

tests/Unit/V2/FailureFactoryRestoreTest.php

@@ -9,6 +9,8 @@
 use Exception;
 use RuntimeException;
 use Tests\TestCase;
+use Workflow\Serializers\Serializer;
+use Workflow\V2\Exceptions\RestoredWorkflowException;
 use TypeError;
 use Workflow\V2\Support\FailureFactory;
 
@@ -68,4 +70,30 @@ public function testRestoresBaseException(): void
         $this->assertInstanceOf(Exception::class, $restored);
         $this->assertSame('base exception sanity check', $restored->getMessage());
     }
+
+    public function testReplayPreservesStructuredFailureMetadata(): void
+    {
+        $payload = [
+            'class' => RuntimeException::class,
+            'type' => 'planned.python.failure',
+            'message' => 'planned python failure',
+            'non_retryable' => true,
+            'details_payload_codec' => 'avro',
+            'details' => Serializer::serializeWithCodec('avro', ['label' => 'planned-python-failure']),
+        ];
+
+        $restored = FailureFactory::restoreForReplay($payload);
+
+        $this->assertInstanceOf(RestoredWorkflowException::class, $restored);
+        $this->assertSame('planned python failure', $restored->getMessage());
+        $failurePayload = $restored->failurePayload();
+
+        $this->assertSame(RuntimeException::class, $failurePayload['class'] ?? null);
+        $this->assertSame('planned.python.failure', $failurePayload['type'] ?? null);
+        $this->assertSame('planned python failure', $failurePayload['message'] ?? null);
+        $this->assertSame(0, $failurePayload['code'] ?? null);
+        $this->assertTrue($failurePayload['non_retryable'] ?? false);
+        $this->assertSame('avro', $failurePayload['details_payload_codec'] ?? null);
+        $this->assertSame($payload['details'], $failurePayload['details'] ?? null);
+    }
 }