Better exceptions (#222)

Author: rmcdaniel

.github/workflows/php.yml

@@ -57,7 +57,7 @@ jobs:
       run: vendor/bin/ecs check
 
     - name: Run static analysis via PHPStan
-      run: vendor/bin/phpstan --xdebug analyse src tests
+      run: vendor/bin/phpstan analyse src tests
 
     - name: Create databases
       run: |

.gitignore

@@ -3,6 +3,7 @@ composer.lock
 vendor
 coverage
 .env
+.phpunit.cache
 .phpunit.result.cache
 .php_cs.cache
 .php-cs-fixer.cache

src/Traits/Timers.php

@@ -5,7 +5,6 @@
 namespace Workflow\Traits;
 
 use Carbon\CarbonInterval;
-use Illuminate\Database\QueryException;
 use React\Promise\Deferred;
 use React\Promise\PromiseInterface;
 use function React\Promise\resolve;
@@ -64,7 +63,7 @@ public static function timer($seconds): PromiseInterface
                             'class' => Signal::class,
                             'result' => Serializer::serialize(true),
                         ]);
-                } catch (QueryException $exception) {
+                } catch (\Illuminate\Database\UniqueConstraintViolationException $exception) {
                     // already logged
                 }
             }

src/WorkflowStub.php

@@ -4,7 +4,6 @@
 
 namespace Workflow;
 
-use Illuminate\Database\QueryException;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Carbon;
 use Illuminate\Support\Traits\Macroable;
@@ -220,15 +219,11 @@ public function startAsChild(StoredWorkflow $parentWorkflow, int $index, $now, .
 
     public function fail($exception): void
     {
-        try {
-            $this->storedWorkflow->exceptions()
-                ->create([
-                    'class' => $this->storedWorkflow->class,
-                    'exception' => Serializer::serialize($exception),
-                ]);
-        } catch (QueryException) {
-            // already logged
-        }
+        $this->storedWorkflow->exceptions()
+            ->create([
+                'class' => $this->storedWorkflow->class,
+                'exception' => Serializer::serialize($exception),
+            ]);
 
         $this->storedWorkflow->status->transitionTo(WorkflowFailedStatus::class);
 
@@ -267,7 +262,7 @@ public function next($index, $now, $class, $result): void
                     'class' => $class,
                     'result' => Serializer::serialize($result),
                 ]);
-        } catch (QueryException) {
+        } catch (\Illuminate\Database\UniqueConstraintViolationException $exception) {
             // already logged
         }
 

tests/TestCase.php

@@ -25,11 +25,7 @@ public static function setUpBeforeClass(): void
         }
 
         for ($i = 0; $i < self::NUMBER_OF_WORKERS; $i++) {
-            self::$workers[$i] = new Process([
-                'php',
-                __DIR__ . '/../vendor/orchestra/testbench-core/laravel/artisan',
-                'queue:work',
-            ]);
+            self::$workers[$i] = new Process(['php', __DIR__ . '/../vendor/bin/testbench', 'queue:work']);
             self::$workers[$i]->start();
         }
     }

tests/Unit/Listeners/MonitorActivityCompletedTest.php

@@ -15,6 +15,10 @@ final class MonitorActivityCompletedTest extends TestCase
 {
     public function testHandle(): void
     {
+        $this->app->make('cache')
+            ->store()
+            ->clear();
+
         config([
             'workflows.monitor_url' => 'http://test',
         ]);

tests/Unit/Listeners/MonitorActivityFailedTest.php

@@ -15,6 +15,10 @@ final class MonitorActivityFailedTest extends TestCase
 {
     public function testHandle(): void
     {
+        $this->app->make('cache')
+            ->store()
+            ->clear();
+
         config([
             'workflows.monitor_url' => 'http://test',
         ]);

tests/Unit/Listeners/MonitorActivityStartedTest.php

@@ -15,6 +15,10 @@ final class MonitorActivityStartedTest extends TestCase
 {
     public function testHandle(): void
     {
+        $this->app->make('cache')
+            ->store()
+            ->clear();
+
         config([
             'workflows.monitor_url' => 'http://test',
         ]);

tests/Unit/Listeners/MonitorWorkflowCompletedTest.php

@@ -14,6 +14,10 @@ final class MonitorWorkflowCompletedTest extends TestCase
 {
     public function testHandle(): void
     {
+        $this->app->make('cache')
+            ->store()
+            ->clear();
+
         config([
             'workflows.monitor_url' => 'http://test',
         ]);

tests/Unit/Listeners/MonitorWorkflowFailedTest.php

@@ -14,6 +14,10 @@ final class MonitorWorkflowFailedTest extends TestCase
 {
     public function testHandle(): void
     {
+        $this->app->make('cache')
+            ->store()
+            ->clear();
+
         config([
             'workflows.monitor_url' => 'http://test',
         ]);