Use line-io in saying-hello

Author: durimkryeziu

saying-hello/build.gradle

@@ -3,6 +3,8 @@ plugins {
 }
 
 dependencies {
+    implementation(project(':line-io'))
+    testImplementation(testFixtures(project(':line-io')))
     testImplementation(libs.assertj.core)
     testImplementation(libs.junit.jupiter)
 }

saying-hello/src/main/java/dev/delivercraft/hello/GreetPrinter.java

@@ -1,38 +1,27 @@
 package dev.delivercraft.hello;
 
-import java.io.InputStream;
-import java.io.PrintStream;
+import dev.delivercraft.io.LineReader;
+import dev.delivercraft.io.LineWriter;
+
 import java.util.Objects;
-import java.util.Scanner;
 
 final class GreetPrinter {
 
-    private final InputStream inputStream;
+    private final LineReader lineReader;
 
-    private final PrintStream printStream;
+    private final LineWriter lineWriter;
 
-    GreetPrinter(InputStream inputStream, PrintStream printStream) {
-        Objects.requireNonNull(inputStream, "inputStream must not be null");
-        Objects.requireNonNull(printStream, "printStream must not be null");
-        this.inputStream = inputStream;
-        this.printStream = printStream;
+    GreetPrinter(LineReader lineReader, LineWriter lineWriter) {
+        Objects.requireNonNull(lineReader, "lineReader must not be null");
+        Objects.requireNonNull(lineWriter, "lineWriter must not be null");
+        this.lineReader = lineReader;
+        this.lineWriter = lineWriter;
     }
 
     void sayHello() {
-        askForName();
-        String name = readName();
-        this.printStream.printf("Hello, %s, nice to meet you!%n", name);
-    }
-
-    @SuppressWarnings("PMD.SystemPrintln")
-    private void askForName() {
-        System.out.print("What is your name? ");
-    }
-
-    private String readName() {
-        try (Scanner scanner = new Scanner(this.inputStream)) {
-            return scanner.nextLine();
-        }
+        this.lineWriter.write("What is your name? ");
+        String name = this.lineReader.readLine();
+        this.lineWriter.writeLine("Hello, %s, nice to meet you!".formatted(name));
     }
 
 }

saying-hello/src/main/java/dev/delivercraft/hello/Main.java

@@ -1,9 +1,16 @@
 package dev.delivercraft.hello;
 
+import dev.delivercraft.io.InputStreamLineReader;
+import dev.delivercraft.io.LineReader;
+import dev.delivercraft.io.LineWriter;
+import dev.delivercraft.io.OutputStreamLineWriter;
+
 public final class Main {
 
     void main() {
-        GreetPrinter greetPrinter = new GreetPrinter(System.in, System.out);
+        LineReader lineReader = new InputStreamLineReader(System.in);
+        LineWriter lineWriter = new OutputStreamLineWriter(System.out);
+        GreetPrinter greetPrinter = new GreetPrinter(lineReader, lineWriter);
         greetPrinter.sayHello();
     }
 

saying-hello/src/test/java/dev/delivercraft/hello/GreetPrinterTests.java

@@ -1,26 +1,53 @@
 package dev.delivercraft.hello;
 
-import static org.assertj.core.api.Assertions.assertThat;
-
-import java.io.ByteArrayInputStream;
-import java.io.ByteArrayOutputStream;
-import java.io.PrintStream;
+import dev.delivercraft.io.CapturingLineWriter;
+import dev.delivercraft.io.LineReader;
+import dev.delivercraft.io.LineWriter;
+import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 class GreetPrinterTests {
 
+    @Test
+    void sayHello_ShouldAskForName() {
+        LineReader lineReader = () -> "Durim";
+        LineWriter lineWriter = new CapturingLineWriter();
+        GreetPrinter greetPrinter = new GreetPrinter(lineReader, lineWriter);
+
+        greetPrinter.sayHello();
+
+        assertThat(lineWriter.toString())
+                .containsOnlyOnce("What is your name?");
+    }
+
     @ParameterizedTest(name = "Given name: {0}")
     @ValueSource(strings = {"Durim", "John Doe"})
     void sayHello_GivenNameIsProvided_ShouldGreetProperly(String name) {
-        ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
-        GreetPrinter greetPrinter = new GreetPrinter(new ByteArrayInputStream(name.getBytes()),
-                new PrintStream(outputStream));
+        LineReader lineReader = () -> name;
+        LineWriter lineWriter = new CapturingLineWriter();
+        GreetPrinter greetPrinter = new GreetPrinter(lineReader, lineWriter);
+
+        greetPrinter.sayHello();
+
+        assertThat(lineWriter.toString())
+                .containsOnlyOnce("Hello, %s, nice to meet you!".formatted(name) + System.lineSeparator());
+    }
+
+    @ParameterizedTest(name = "Given name: {0}")
+    @ValueSource(strings = {"Durim", "John Doe"})
+    void sayHello_GivenNameIsProvided_ShouldOutputPromptAndGreeting(String name) {
+        LineReader lineReader = () -> name;
+        LineWriter lineWriter = new CapturingLineWriter();
+        GreetPrinter greetPrinter = new GreetPrinter(lineReader, lineWriter);
 
         greetPrinter.sayHello();
 
-        assertThat(outputStream)
-                .hasToString("Hello, %s, nice to meet you!%n", name);
+        assertThat(lineWriter)
+                .hasToString("What is your name? Hello, %s, nice to meet you!%s".formatted(name,
+                        System.lineSeparator()));
     }
 
 }