Save Hue effects state and decode philips_raw from z2m to update light state#14
Merged
Conversation
This let's use both remove some old state hacks and ensure that Bifrost's state is up to date with Hue changes from z2m. It also let's us parse the raw update directly instead of relying on z2m to do this correctly.
duvholt
force-pushed
the
feat/effects-state
branch
from
e846afd to
decba08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
philips_rawwas introduced in zigbee2mqtt which reports the raw state for Philips Hue lights.Koenkk/zigbee-herdsman-converters#11655
The format is already documented here: https://github.com/duvholt/bifrost/blob/master/doc/hue-zigbee-format.md
Since Bifrost already has support for decoding this format it was relatively straightforward to use this to update our internal light state instead of using attributes from zigbee2mqtt.
The most noticeable change from this is that Philips Hue effects and gradient lights should now properly reflect their status in the app.