Handle new socket connections to existing entertainment stream#15
Draft
duvholt wants to merge 2 commits into
Draft
Handle new socket connections to existing entertainment stream#15duvholt wants to merge 2 commits into
duvholt wants to merge 2 commits into
Conversation
Clients like iLightShow create new socket connections before actually starting the entertainment stream. This caused some reconnect loops where connections timed out while new connections were created. Instead we create a listener per socket connection since it's straightforward to handle multiple connections at the same time. This might also fix some disconnection problems for longer entertainment streams where a client might reconnect in the middle of a stream.
This seems to fix already streaming clients reconnecting after Bifrost has been restarted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients like iLightShow sometimes end up creating multiple connections when starting the entertainment stream. Previously we stopped the entertainment stream when the socket closed, but since a new socket may already have been opening this ended up creating a loop of start and stop after the streams timed out.
This PR is not completely ready since it's missing support for stopping the entertainment stream when all sockets are closed.