- Removing rx dependencies

- sdk 25 for lib
- Bugfix

Author: dvdciri

circle.yml

@@ -10,7 +10,7 @@ dependencies:
   pre:
     - echo y | android update sdk --no-ui --all --filter "tools"
     - echo y | android update sdk --no-ui --all --filter "build-tools-25.0.0"
-    - echo y | android update sdk --no-ui --all --filter tool,extra-android-m2repository,extra-android-support,extra-google-google_play_services,extra-google-m2repository,android-23
+    - echo y | android update sdk --no-ui --all --filter tool,extra-android-m2repository,extra-android-support,extra-google-google_play_services,extra-google-m2repository,android-25
     - echo y | android update sdk --no-ui --all --filter build-tools-25.0.0
 
 test:

library/multichoicerecyclerview/build.gradle

@@ -11,7 +11,7 @@ ext {
     PUBLISH_VERSION = '2.4.0'
     SUPPORT_LIBRARY_VERSION = '24.2.1'
     BUILD_TOOLS = "25.0.0"
-    TARGET_SDK = 23
+    TARGET_SDK = 25
 
     PUBLISH_ARTIFACT_ID = 'multichoicerecyclerview'
     PUBLISH_GROUP_ID = 'com.davidecirillo.multichoicerecyclerview'

library/multichoicerecyclerview/src/main/java/com/davidecirillo/multichoicerecyclerview/MultiChoiceAdapter.java

@@ -168,11 +168,15 @@ public void onRestoreInstanceState(Bundle savedInstanceState) {
     }
 
     /**
-     * Use this method instead of {@link RecyclerView.Adapter#notifyDataSetChanged()}
-     * and it'll automatically handle the list refresh without loosing current item state
+     * <b>Use this method instead of {@link RecyclerView.Adapter#notifyDataSetChanged()} for
+     * notifying a change in the data set.</b>
+     *
+     * <b>NOTE: The new data will not keep the current selected status, all the item will be reset to INACTIVE.</b>
+     * 
      */
-    public void refreshDataSet() {
-        refreshDataSetInternal();
+    public void notifyAdapterDataSetChanged() {
+        // TODO: 10/03/2017 Create some possible instrumentation tests around this functionality
+        notifyAdapterDataSetChangedInternal();
     }
 
     //endregion
@@ -314,24 +318,10 @@ private void performAll(Action action) {
         }
     }
 
-    private void refreshDataSetInternal() {
-        if (mItemList.isEmpty()) {
-            for (int i = 0; i < getItemCount(); i++) {
-                mItemList.put(i, State.INACTIVE);
-            }
-        } else if (mItemList.size() > getItemCount()) { // We have new items, let's add only the new ones as inactive
-            for (int i = 0; i < getItemCount(); i++) {
-                if (mItemList.get(i) != null) {
-                    mItemList.put(i, State.INACTIVE);
-                }
-            }
-        } else {
-            // Keep just the number of item in the getItemCount remove all the others.
-            for (int i = 0; i < mItemList.size(); i++) {
-                if (i + 1 > getItemCount()) {
-                    mItemList.remove(i);
-                }
-            }
+    private void notifyAdapterDataSetChangedInternal() {
+        // TODO: 10/03/2017 create some unit tests on this
+        for (int i = 0; i < getItemCount(); i++) {
+            mItemList.put(i, State.INACTIVE);
         }
         processNotifyDataSetChanged();
     }
@@ -345,7 +335,7 @@ public void onClearButtonPressed() {
     public void onAttachedToRecyclerView(RecyclerView recyclerView) {
         mRecyclerView = recyclerView;
 
-        refreshDataSetInternal();
+        notifyAdapterDataSetChangedInternal();
         super.onAttachedToRecyclerView(recyclerView);
     }
 

sample/build.gradle

@@ -5,7 +5,7 @@ ext {
     PUBLISH_VERSION = '2.0.0'
     SUPPORT_LIBRARY_VERSION = '24.2.1'
     BUILD_TOOLS = "25.0.0"
-    TARGET_SDK = 23
+    TARGET_SDK = 25
 }
 
 android {
@@ -81,9 +81,6 @@ dependencies {
     compile "com.android.support:design:${SUPPORT_LIBRARY_VERSION}"
     compile 'com.jakewharton:butterknife:8.1.0'
     apt 'com.jakewharton:butterknife-compiler:8.1.0'
-    // RxAndroid - asynchronous operations
-    compile 'io.reactivex:rxandroid:1.0.1'
-    compile 'io.reactivex:rxjava:1.0.14'
     compile 'com.squareup.picasso:picasso:2.5.2'
     // Testing-only dependencies
     testCompile 'junit:junit:4.10'