-
Notifications
You must be signed in to change notification settings - Fork 9
feat: implement HA-side accumulation for monthly spent sensor #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dvejsada
merged 4 commits into
dvejsada:dev
from
eMeF1:feature/monthly-spent-accumulation
Dec 8, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
108922c
Add get_earliest_order utility function and update sensors to use it …
eMeF1 a89b3f3
feat: implement HA-side accumulation for monthly spent sensor
eMeF1 119ac3e
fix: remove conflicting native_unit_of_measurement
eMeF1 670e50d
fix: address PR review comments
eMeF1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timezone inconsistency: In
_check_and_reset_month(),self._last_resetis set usingdatetime.now(ZoneInfo("Europe/Prague"))(line 500), but in__init__()and when checking month boundaries, the code usesdatetime.now()without timezone (lines 444, 494, 512). This could lead to inconsistent datetime comparisons or timezone-related issues. Consider using timezone-aware datetime consistently throughout, particularlydatetime.now(ZoneInfo("Europe/Prague"))for all datetime.now() calls in this class.