fix: follow established callback pattern for MonthlySpent sensor#55
Merged
Merged
Conversation
- Remove custom _handle_coordinator_update method - Use async_write_ha_state directly as callback (matches all other sensors) - Move processing logic to native_value property (lazy evaluation) - Follows the established pattern used by 40+ other sensors in codebase
Contributor
Author
|
@dvejsada, all tested and working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the MonthlySpent sensor not updating by following the established callback pattern used by all other sensors in the codebase.
Problem
After PR #54, the MonthlySpent sensor was not updating because it used a custom async callback handler (
_handle_coordinator_update) that didn't work with the synchronous callback system inRohlikAccount.publish_updates().Solution
_handle_coordinator_updatemethodasync_write_ha_statedirectly as callback (matches all 40+ other sensors)native_valueproperty (lazy evaluation pattern)Changes
async_write_ha_statedirectly_check_and_reset_month()and_process_new_orders()calls tonative_valuepropertyasync_will_remove_from_hassto remove correct callbackTesting
Related
Follow-up fix to #54 - addresses callback pattern issue discovered during testing.