Fix RecursionError in DeliveryTime sensor#57
Merged
Conversation
- Fix infinite recursion when no delivery announcement exists but order is placed - Get delivery time from order data using get_earliest_order() and parse_delivery_datetime_string() - Fix return type from str | None to datetime | None to match SensorDeviceClass.TIMESTAMP
…nouncements stop - Add RestoreEntity to DeliveryInfo and DeliveryTime sensors - Fix infinite recursion bug in DeliveryTime.native_value - Preserve last known values when announcements stop but order still exists - Restore state on Home Assistant restart - Clear values when is_ordered becomes False This fixes the issue where sensor.rohlik_delivery_information and sensor.rohlik_delivery_time would reset to None when announcements stop broadcasting, even though binary_sensor.rohlik_next_order_made is still True (right before delivery time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
What was wrong
The DeliveryTime sensor crashed with a RecursionError when an order was placed but no delivery announcement existed. The code called itself infinitely, breaking the sensor.
What this fixes
Changes