fix: display hot-plug length re-apply, constraint and observer leaks

Absorbs the still-relevant pieces of three community PRs that overlapped this branch, with authorship credit:

- collapse length re-applies to the live separator when displays change, and isCollapsed compares > btnHiddenLength so the state survives the recompute; collapse sizing uses frame.width x2 capped at the documented 10,000pt NSStatusItem maximum (from #354)
- NSLayoutConstraint.deactivate before removeFromSuperview in removeAllSubViews, plugging the tutorial-view rebuild leak (from #335)
- PreferencesViewController balances its prefsChanged observer in deinit (from #335/#346)

Co-authored-by: Laveez <niko.muukkonen1@gmail.com>
Co-authored-by: huynguyenh <hoanghuy2908@gmail.com>
Co-authored-by: Rob Mulder <hallo@robmulder.com>

Author: 4 people

hidden/Extensions/StackView+Extension.swift

@@ -11,6 +11,9 @@ import Cocoa
 extension NSStackView {
     func removeAllSubViews() {
         for view in self.views {
+            // Deactivate constraints before removal or they leak on every
+            // tutorial-view rebuild (PR #335).
+            NSLayoutConstraint.deactivate(view.constraints)
             view.removeFromSuperview()
         }
     }

hidden/Features/Preferences/PreferencesViewController.swift

@@ -55,7 +55,12 @@ class PreferencesViewController: NSViewController {
         createTutorialView()
         NotificationCenter.default.addObserver(self, selector: #selector(updateData), name: .prefsChanged, object: nil)
     }
-    
+
+    deinit {
+        // Balance the viewDidLoad observer (PRs #335/#346).
+        NotificationCenter.default.removeObserver(self, name: .prefsChanged, object: nil)
+    }
+
     static func initWithStoryboard() -> PreferencesViewController {
         let vc = NSStoryboard(name:"Main", bundle: nil).instantiateController(withIdentifier: "prefVC") as! PreferencesViewController
         return vc

hidden/Features/StatusBar/StatusBarController.swift

@@ -28,7 +28,9 @@ class StatusBarController {
     private let imgIconLine = NSImage(named:NSImage.Name("ic_line"))
 
     private var isCollapsed: Bool {
-        return self.btnSeparate.length == self.btnHiddenCollapseLength
+        // Compare with > rather than == so the state survives updateCollapsedLengths
+        // changing btnHiddenCollapseLength while the bar is collapsed (PR #354).
+        return self.btnSeparate.length > self.btnHiddenLength
     }
 
     private var isBtnSeparateValidPosition: Bool {
@@ -125,18 +127,27 @@ class StatusBarController {
     }
 
     @objc private func handleScreenParametersChanged() {
+        // Re-apply the recomputed length to the LIVE item when collapsed, or a
+        // display hot-plug leaves the separator at a stale length (PR #354).
+        let wasCollapsed = isCollapsed
         updateCollapsedLengths()
+        if wasCollapsed {
+            btnSeparate.length = btnHiddenCollapseLength
+            if Preferences.areSeparatorsHidden {
+                btnAlwaysHidden?.length = btnAlwaysHiddenEnableExpandCollapseLength
+            }
+        }
     }
-    
+
     private func updateCollapsedLengths() {
         // The menubar replicates across every attached display, so the collapse
         // length must cover the WIDEST screen, not NSScreen.main (the focused one);
         // sizing from a narrower screen leaks hidden icons on wider displays.
-        let screenWidth = NSScreen.screens.map { $0.visibleFrame.width }.max() ?? 1728
-        // Keep collapse length bounded to avoid pathological layout/memory behavior
-        // on newer macOS versions while still fully hiding the trailing section.
-        // 6000 covers 5K2K ultrawides (5120pt); was 4000.
-        let boundedCollapseLength = max(500, min(screenWidth + 200, 6000))
+        // frame.width, not visibleFrame: the menubar spans the full frame width.
+        let screenWidth = NSScreen.screens.map { $0.frame.width }.max() ?? 1728
+        // Keep collapse length bounded to avoid pathological layout/memory behavior;
+        // macOS enforces a hard 10,000pt maximum on NSStatusItem.length (PR #354).
+        let boundedCollapseLength = max(500, min(screenWidth * 2, 10_000))
         btnHiddenCollapseLength = boundedCollapseLength
         btnAlwaysHiddenEnableExpandCollapseLength = Preferences.alwaysHiddenSectionEnabled ? boundedCollapseLength : 0
     }