Skip to content

fix: properly hide menu bar items on ultra-wide and multi-monitor setups #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laveez wants to merge 1 commit into
base: develop
Choose a base branch
from
+15 −7
Open

fix: properly hide menu bar items on ultra-wide and multi-monitor setups #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions hidden/Features/StatusBar/StatusBarController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class StatusBarController {
private let imgIconLine = NSImage(named:NSImage.Name("ic_line"))

private var isCollapsed: Bool {
return self.btnSeparate.length == self.btnHiddenCollapseLength
return self.btnSeparate.length > self.btnHiddenLength
}

private var isBtnSeparateValidPosition: Bool {
Expand Down Expand Up @@ -80,16 +80,24 @@ class StatusBarController {
}

@objc private func handleScreenParametersChanged() {
let wasCollapsed = isCollapsed
updateCollapsedLengths()
if wasCollapsed {
btnSeparate.length = btnHiddenCollapseLength
if Preferences.areSeparatorsHidden {
btnAlwaysHidden?.length = btnAlwaysHiddenEnableExpandCollapseLength
}
}
}

private func updateCollapsedLengths() {
let screenWidth = NSScreen.main?.visibleFrame.width ?? 1728
// Keep collapse length bounded to avoid pathological layout/memory behavior
// on newer macOS versions while still fully hiding the trailing section.
let boundedCollapseLength = max(500, min(screenWidth + 200, 4000))
btnHiddenCollapseLength = boundedCollapseLength
btnAlwaysHiddenEnableExpandCollapseLength = Preferences.alwaysHiddenSectionEnabled ? boundedCollapseLength : 0
// Use the widest screen across all displays so the collapse length is always
// large enough, regardless of which display has focus.
// macOS enforces a hard 10,000pt maximum for NSStatusItem.length.
let screenWidth = NSScreen.screens.map { $0.frame.width }.max() ?? 1728
let collapseLength = max(500, min(screenWidth * 2, 10_000))
btnHiddenCollapseLength = collapseLength
btnAlwaysHiddenEnableExpandCollapseLength = Preferences.alwaysHiddenSectionEnabled ? collapseLength : 0
}

private func setupUI() {
Expand Down