Enable pgn-at-pos test for point-min, with new value#209
Open
rolandwalker wants to merge 3 commits intomasterfrom
Open
Enable pgn-at-pos test for point-min, with new value#209rolandwalker wants to merge 3 commits intomasterfrom
rolandwalker wants to merge 3 commits intomasterfrom
Conversation
This always was a corner case per the docstring. What is the meaningful PGN at point-min? The new code says it is the full set of header tagpairs; the old code said the first tagpair. Both seem acceptable. Neither include any moves.
|
The new code definitely treats the header as an atomic entity. The main reason was to reduce code. But I also felt odd when using only the tag pairs up to point in headers with a FEN. The board would suddenly jump to the initial position when the point reached that tag pair. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This always was a corner case per the docstring. What is the meaningful PGN at point-min? The new code says it is the full set of header tagpairs; the old code said the first tagpair. Both seem acceptable. Neither include any moves.
xref #208
cc @dekrueger