Skip to content

Change popups: resize horizontally and center vertically#49

Open
dwcoates wants to merge 1 commit intomasterfrom
DC/change-popup-handling
Open

Change popups: resize horizontally and center vertically#49
dwcoates wants to merge 1 commit intomasterfrom
DC/change-popup-handling

Conversation

@dwcoates
Copy link
Copy Markdown
Owner

@dwcoates dwcoates commented Nov 20, 2019

This change makes board image centered vertically in popup. It also resizes the popup window horizontally to fix to image.

I could not get the image to center horizontally.

You might not notice a difference without a emacs -Q

@dwcoates
Copy link
Copy Markdown
Owner Author

dwcoates commented Nov 20, 2019

It seems to create window too early, so it hiccups on the first call. I should fix that

@dwcoates
Copy link
Copy Markdown
Owner Author

A work in progress. Later, I'll try to make it popup below/right intelligently.

@rolandwalker
Copy link
Copy Markdown
Collaborator

The variable win in (let ( … (win (get-buffer-window buf)) … was perhaps badly named. It's expected to routinely be nil — when the window doesn't exist yet. That way setting window properties only such as (set-window-dedicated-p win t) happens only on the first display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants