Skip to content

chore: update rand crate to 0.10.1#492

Merged
dyc3 merged 3 commits into
masterfrom
pullfrog/0-update-rand-crate
Apr 14, 2026
Merged

chore: update rand crate to 0.10.1#492
dyc3 merged 3 commits into
masterfrom
pullfrog/0-update-rand-crate

Conversation

@pullfrog

@pullfrog pullfrog Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Updated rand to 0.10.1 in both workspace crates
  • Regenerated Cargo.lock for the new dependency graph
  • Migrated code to the rand 0.10 APIs:
    • thread_rng -> rng
    • distributions -> distr
    • OsRng -> SysRng for local random byte generation
    • fill -> try_fill_bytes with explicit error handling
  • Kept RSA encryption compatibility by using rsa::rand_core::OsRng
  • Restored deterministic steamguard test RNG behavior with a rand 0.8 dev dependency alias (rand_08) for the existing StepRng based test vectors

Validation

  • cargo test
  • cargo test -p steamguard

Pullfrog  | View workflow run | Triggered by Pullfrog | Using GPT Codex𝕏

@pullfrog pullfrog Bot requested a review from dyc3 April 14, 2026 13:09
Comment thread steamguard/Cargo.toml Outdated
@pullfrog

pullfrog Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the requested change by removing the extra rand 0.8 dev dependency and replacing test usage with a local deterministic RNG implemented against rsa::rand_core. Ran cargo test -p steamguard test_encrypt_password -- --nocapture successfully, pushed two commits to pullfrog/0-update-rand-crate, replied to the review comment, and resolved the thread.

Task list (6/6 completed)
  • Checkout PR chore: update rand crate to 0.10.1 #492 branch
  • Fetch review comments for review 4106223940
  • Implement requested code changes
  • Run quality checks and commit
  • Push branch, reply to comments, resolve threads
  • Report final progress

Pullfrog  | View workflow run | Triggered by Pullfrog | Using GPT Codex𝕏

@dyc3 dyc3 merged commit 7f6542c into master Apr 14, 2026
3 checks passed
@dyc3 dyc3 deleted the pullfrog/0-update-rand-crate branch April 14, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant