Normalize ticker to uppercase in x/listing and make existence-checking case-insensitive in x/prices (#3330)

Author: tqin7

protocol/x/listing/keeper/listing.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"math"
 	"math/big"
+	"strings"
 
 	"github.com/dydxprotocol/v4-chain/protocol/indexer/indexer_manager"
 	"github.com/dydxprotocol/v4-chain/protocol/lib/slinky"
@@ -43,6 +44,7 @@ func (k Keeper) CreateMarket(
 	ctx sdk.Context,
 	ticker string,
 ) (marketId uint32, err error) {
+	ticker = strings.ToUpper(ticker)
 	marketId = k.PricesKeeper.AcquireNextMarketID(ctx)
 
 	// Get market details from marketmap

protocol/x/prices/keeper/market.go

@@ -2,6 +2,7 @@ package keeper
 
 import (
 	"fmt"
+	"strings"
 
 	gogotypes "github.com/cosmos/gogoproto/types"
 
@@ -41,7 +42,7 @@ func (k Keeper) CreateMarket(
 	}
 	// Stateful Validation
 	for _, market := range k.GetAllMarketParams(ctx) {
-		if market.Pair == marketParam.Pair {
+		if strings.EqualFold(market.Pair, marketParam.Pair) {
 			return types.MarketParam{}, errorsmod.Wrap(
 				types.ErrMarketParamPairAlreadyExists,
 				marketParam.Pair,

protocol/x/prices/keeper/market_param.go

@@ -2,6 +2,7 @@ package keeper
 
 import (
 	"sort"
+	"strings"
 
 	errorsmod "cosmossdk.io/errors"
 	"github.com/dydxprotocol/v4-chain/protocol/daemons/pricefeed/metrics"
@@ -41,7 +42,7 @@ func (k Keeper) ModifyMarketParam(
 
 	// Validate update is permitted.
 	for _, market := range k.GetAllMarketParams(ctx) {
-		if market.Pair == updatedMarketParam.Pair && market.Id != updatedMarketParam.Id {
+		if strings.EqualFold(market.Pair, updatedMarketParam.Pair) && market.Id != updatedMarketParam.Id {
 			return types.MarketParam{}, errorsmod.Wrap(types.ErrMarketParamPairAlreadyExists, updatedMarketParam.Pair)
 		}
 	}