Skip to content

Add a higher timeout#3335

Merged
Kefancao merged 1 commit into
mainfrom
kefan/timeout
Apr 16, 2026
Merged

Add a higher timeout#3335
Kefancao merged 1 commit into
mainfrom
kefan/timeout

Conversation

@Kefancao

@Kefancao Kefancao commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Changelist

Add a higher timeout

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • Bug Fixes
    • Extended timeout duration for message generation operations from 60 to 300 seconds, providing more time for processing to complete before timing out.

@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2e3866ab-573d-4507-b3e6-836f75797e95

📥 Commits

Reviewing files that changed from the base of the PR and between ecfb2d1 and 2703abc.

📒 Files selected for processing (1)
  • indexer/services/comlink/src/helpers/skip-helper.ts

📝 Walkthrough

Walkthrough

A single constant value in the skip helper service was increased from 60 seconds to 300 seconds, extending the timeout duration for message generation operations.

Changes

Cohort / File(s) Summary
Timeout Configuration Update
indexer/services/comlink/src/helpers/skip-helper.ts
skipMessagesTimeoutSeconds constant increased from '60' to '300' to extend message generation timeout from 1 minute to 5 minutes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • vincentwschau

Poem

🐰 A timeout stretched, five minutes long,
Where messages once rushed along,
Now patience blooms, the clock runs slow,
Giving time for works to grow! ⏱️✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kefan/timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kefancao Kefancao merged commit f18dcb9 into main Apr 16, 2026
39 checks passed
@Kefancao Kefancao deleted the kefan/timeout branch April 16, 2026 16:14
@Kefancao

Copy link
Copy Markdown
Contributor Author

@mergify backport release/indexer/v9.x

@mergify

mergify Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

backport release/indexer/v9.x

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 16, 2026
(cherry picked from commit f18dcb9)
@mergify mergify Bot mentioned this pull request Apr 16, 2026
6 tasks
Kefancao added a commit that referenced this pull request Apr 16, 2026
Co-authored-by: Kefan Cao <76069770+Kefancao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants