Skip to content

chore: update protocol version#422

Merged
gaonip merged 9 commits into
mainfrom
bohdan/dydx-proto-v9
Sep 23, 2025
Merged

chore: update protocol version#422
gaonip merged 9 commits into
mainfrom
bohdan/dydx-proto-v9

Conversation

@varex83
Copy link
Copy Markdown
Contributor

@varex83 varex83 commented Sep 11, 2025

This PR updates Rust client to v9 version of protocol

@varex83 varex83 requested review from a team as code owners September 11, 2025 12:04
}

// Market mapper revenue share params - returns global revenue share parameters
let market_mapper_params = getter
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this called market mapper ?

tracing::info!("Get market mapper rev share details for market {ETH_USD_PAIR_ID}: {market_mapper_details:?}");

// Unconditional rev share config - returns unconditional revenue share configuration
let unconditional_config = getter.client.get_unconditional_rev_share_config().await?;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the unconditional rev share?

Ok(params)
}

/// Queries for the next CLOB pair ID.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the use of these methods?

/// Set the order router rev share.
///
/// Check [the example](https://github.com/dydxprotocol/v4-clients/blob/main/v4-client-rs/client/examples/validator_get.rs).
pub async fn set_order_router_rev_share(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can remove these

@gaonip gaonip merged commit 81129a0 into main Sep 23, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants