Fix(vm): Use checked_pow to prevent silent i128 wrap in Pow.

Author: dylan-sutton-chavez

compiler/src/modules/vm/mod.rs

@@ -281,11 +281,11 @@ impl<'a> VM<'a> {
                         (true, true) => {
                             let exp = b.as_int();
                             if exp >= 0 {
-                                let result = (a.as_int() as i128).pow(exp as u32);
-                                if result >= Val::INT_MIN as i128 && result <= Val::INT_MAX as i128 {
-                                    Val::int(result as i64)
-                                } else {
-                                    Val::float(result as f64)
+                                match (a.as_int() as i128).checked_pow(exp as u32) {
+                                    Some(result) if result >= Val::INT_MIN as i128
+                                                && result <= Val::INT_MAX as i128 => Val::int(result as i64),
+                                    Some(result) => Val::float(result as f64),
+                                    None => Val::float(fpowi(a.as_int() as f64, exp as i32)),
                                 }
                             } else {
                                 Val::float(fpowi(a.as_int() as f64, exp as i32))

compiler/tests/cases/parser_cases.json

@@ -1618,5 +1618,12 @@
     "names": ["x_1"], 
     "instructions": [["LoadConst",0], ["StoreName",0], ["ReturnValue",0]], 
     "annotations": {}
+  },
+  {
+    "src": "a[0] += 1",
+    "constants": ["0", "1"],
+    "names": ["a_0"],
+    "instructions": [["LoadName",0], ["LoadConst",0], ["Dup2",0], ["GetItem",0], ["LoadConst",1], ["Add",0], ["StoreItem",0], ["ReturnValue",0]],
+    "annotations": {}
   }
 ]

compiler/tests/cases/vm_cases.json

@@ -181,5 +181,17 @@
   {"src": "a = 140737488355328\nprint(-a - 1)", "output": ["-140737488355329"], "result": "None"},
   {"src": "print(-(-(2**47)))", "output": ["140737488355328"], "result": "None"},
   {"src": "a = 140737488355327\nb = 1\nr = 0\nfor i in range(10):\n    r = a + b\nprint(r)", "output": ["140737488355328"], "result": "None"},
-  {"src": "x = -140737488355328\nprint(-x)", "output": ["140737488355328"], "result": "None"}
+  {"src": "x = -140737488355328\nprint(-x)", "output": ["140737488355328"], "result": "None"},
+  {"src": "print(2**62)", "output": ["4611686018427387904"], "result": "None"},
+  {"src": "print(2**63 > 0)", "output": ["True"], "result": "None"},
+  {"src": "print(2**127 > 0)", "output": ["True"], "result": "None"},
+  {"src": "print(2**128 > 0)", "output": ["True"], "result": "None"},
+  {"src": "print(2**129 > 0)", "output": ["True"], "result": "None"},
+  {"src": "print(3**40 > 0)", "output": ["True"], "result": "None"},
+  {"src": "print(2**0)", "output": ["1"], "result": "None"},
+  {"src": "x = [10, 20, 30]\nx[0] += 5\nprint(x)", "output": ["[15, 20, 30]"], "result": "None"},
+  {"src": "x = [10, 20, 30]\nx[1] -= 3\nprint(x)", "output": ["[10, 17, 30]"], "result": "None"},
+  {"src": "x = [2, 3, 4]\nx[2] *= 10\nprint(x)", "output": ["[2, 3, 40]"], "result": "None"},
+  {"src": "d = {'a': 1}\nd['a'] += 99\nprint(d['a'])", "output": ["100"], "result": "None"},
+  {"src": "x = [0]\nx[0] += 1\nx[0] += 1\nx[0] += 1\nprint(x[0])", "output": ["3"], "result": "None"}
 ]