Fix: Stack-buffer to eliminate per-identifier heap allocation.

Author: dylan-sutton-chavez

compiler/src/modules/parser/expr.rs

@@ -227,7 +227,8 @@ impl<'src, I: Iterator<Item = Token>> Parser<'src, I> {
                 self.advance();
                 self.expr();
                 let ver = self.increment_version(&name);
-                let i   = self.chunk.push_name(&Self::ssa_name(&name, ver));
+                let mut buf = [0u8; 128];
+                let i = self.chunk.push_name(Self::ssa_name(&name, ver, &mut buf));
                 self.chunk.emit(OpCode::StoreName, i);
                 self.chunk.emit(OpCode::LoadName,  i);
             }

compiler/src/modules/parser/literals.rs

@@ -120,7 +120,8 @@ impl<'src, I: Iterator<Item = Token>> Parser<'src, I> {
 
             if vars.len() == 1 {
                 let ver = self.increment_version(&vars[0]);
-                let idx = self.chunk.push_name(&Self::ssa_name(&vars[0], ver));
+                let mut buf = [0u8; 128];
+                let idx = self.chunk.push_name(Self::ssa_name(&vars[0], ver, &mut buf));
                 self.chunk.emit(OpCode::StoreName, idx);
             } else {
                 self.chunk.emit(OpCode::UnpackSequence, vars.len() as u16);
@@ -236,7 +237,8 @@ impl<'src, I: Iterator<Item = Token>> Parser<'src, I> {
         }
 
         let v = self.current_version(&name);
-        let i = self.chunk.push_name(&Self::ssa_name(&name, v));
+        let mut buf = [0u8; 128];
+        let i = self.chunk.push_name(Self::ssa_name(&name, v, &mut buf));
         self.chunk.emit(OpCode::LoadName, i);
         let a = self.parse_args();
         self.chunk.emit(OpCode::Call, a);
@@ -328,7 +330,8 @@ impl<'src, I: Iterator<Item = Token>> Parser<'src, I> {
         self.chunk.emit(OpCode::MakeClass, ci);
 
         let ver = self.increment_version(&cname);
-        let i   = self.chunk.push_name(&Self::ssa_name(&cname, ver));
+        let mut buf = [0u8; 128];
+        let i = self.chunk.push_name(Self::ssa_name(&cname, ver, &mut buf));
         self.chunk.emit(OpCode::StoreName, i);
     }
 
@@ -357,7 +360,8 @@ impl<'src, I: Iterator<Item = Token>> Parser<'src, I> {
         }
 
         let ver = self.increment_version(&fname);
-        let i = self.chunk.push_name(&Self::ssa_name(&fname, ver));
+        let mut buf = [0u8; 128];
+        let i = self.chunk.push_name(Self::ssa_name(&fname, ver, &mut buf));
         self.chunk.emit(OpCode::StoreName, i);
     }
 

compiler/src/modules/parser/mod.rs

@@ -131,10 +131,13 @@ impl<'src, I: Iterator<Item = Token>> Parser<'src, I> {
         for name in divergent {
             let va = *a.get(name).unwrap_or(&0);
             let vb = *b.get(name).unwrap_or(&0);
-            let ia = self.chunk.push_name(&Self::ssa_name(name, va));
-            let ib = self.chunk.push_name(&Self::ssa_name(name, vb));
+            let mut ba = [0u8; 128];
+            let mut bb = [0u8; 128];
+            let mut bx = [0u8; 128];
+            let ia = self.chunk.push_name(Self::ssa_name(name, va, &mut ba));
+            let ib = self.chunk.push_name(Self::ssa_name(name, vb, &mut bb));
             let v  = self.increment_version(name);
-            let ix = self.chunk.push_name(&Self::ssa_name(name, v));
+            let ix = self.chunk.push_name(Self::ssa_name(name, v, &mut bx));
             self.chunk.phi_sources.push((ia, ib));
             self.chunk.emit(OpCode::Phi, ix);
         }

compiler/src/modules/parser/stmt.rs

@@ -136,8 +136,9 @@ impl<'src, I: Iterator<Item = Token>> Parser<'src, I> {
                 self.advance();
                 let t = self.advance();
                 let name = self.lexeme(&t).to_string();
+                let mut buf = [0u8; 128];
                 let idx = self.chunk.push_name(
-                    &Self::ssa_name(&name, self.current_version(&name))
+                    Self::ssa_name(&name, self.current_version(&name), &mut buf)
                 );
                 self.chunk.emit(OpCode::Del, idx);
                 false