Skip to content

Commit a02668a

Browse files
committed
kmod: remove redundant -mcmodel=large on ppc64le
In PR #1205, Kamalesh reports: ... I see that the -mcmodel=large flag is being passed twice with KBUILD_CFLAGS_MODULE set: gcc -Wp,-MMD,/root/.kpatch/tmp/patch/.livepatch-meminfo.mod.o.d ............ -mcmodel=medium .... -I/root/kpatch/kmod/patch -mcmodel=large -fplugin=/root/kpatch/kpatch-build/gcc-plugins/ppc64le-plugin.so ... -DMODULE -mno-save-toc-indirect -mcmodel=large -mcmodel=large -DKBUILD_BASENAME='"livepatch_meminfo.mod"' -DKBUILD_MODNAME='"livepatch_meminfo"' -D__KBUILD_MODNAME=kmod_livepatch_meminfo -c -o /root/.kpatch/tmp/patch/livepatch-meminfo.mod.o /root/.kpatch/tmp/patch/livepatch-meminfo.mod.c. I loaded the module built without the KBUILD_CFLAGS_MODULE += -mcmodel=large flag and seems to okay. I guess, we can remove the arch specific flag from the Makefile. Suggested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
1 parent 624e5e3 commit a02668a

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

kmod/patch/Makefile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,6 @@ KPATCH_BUILD ?= /lib/modules/$(shell uname -r)/build
22
KPATCH_MAKE = $(MAKE) -C $(KPATCH_BUILD) M=$(PWD) CFLAGS_MODULE='$(CFLAGS_MODULE)'
33
LDFLAGS += $(KPATCH_LDFLAGS)
44

5-
# ppc64le kernel modules are expected to compile with the
6-
# -mcmodel=large flag. This enables 64-bit relocations
7-
# instead of a 32-bit offset from the TOC pointer.
8-
PROCESSOR = $(shell uname -m)
9-
ifeq ($(PROCESSOR), ppc64le)
10-
CFLAGS_MODULE += -mcmodel=large
11-
endif
12-
135
obj-m += $(KPATCH_NAME).o
146
ldflags-y += -T $(src)/kpatch.lds
157
targets += kpatch.lds

0 commit comments

Comments
 (0)