bug: local task definitions should belong to the module that defines the route#17
Open
eojthebrave wants to merge 1 commit into
Open
bug: local task definitions should belong to the module that defines the route#17eojthebrave wants to merge 1 commit into
eojthebrave wants to merge 1 commit into
Conversation
…the route. Move local task definitions for sub-module routes into the sub-module that defines the route. This fixes an issue where if you enable simple_oauth_21, and try and visit /admin/config/people/simple_oauth/oauth-21 but not all the sub-modules are enabled you get an error. The error is caused by Drupal attempting to render all the local task tabs, but some of them point to routes that don't exist if the correspending sub-module doesn't exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move local task definitions for sub-module routes into the sub-module that defines the route. This fixes an issue where if you enable simple_oauth_21, and try and visit /admin/config/people/simple_oauth/oauth-21 but not all the sub-modules are enabled you get an error. The error is caused by Drupal attempting to render all the local task tabs, but some of them point to routes that don't exist if the corresponding sub-module doesn't exist.