fix: disable duplicate checks when threshold <= 0#169
Merged
Conversation
If the threshold is `0`, you're basically saying "show me when a package has 0 or more versions". This will always be true so is a nonsensical value. Similarly, `-1` may be set as a way to turn it off but currently does the opposite (same as `0`). This change means `-1` and `0` behave as "turn off duplicate checks".
|
| 📦 Package | 📋 Versions |
|---|---|
| @actions/http-client | 2 versions
|
| eslint-visitor-keys | 2 versions
|
| ignore | 2 versions
|
💡 To find out what depends on a specific package, run: npm ls example-package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the threshold is
0, you're basically saying "show me when a packagehas 0 or more versions". This will always be true so is a nonsensical
value.
Similarly,
-1may be set as a way to turn it off but currently doesthe opposite (same as
0).This change means
-1and0behave as "turn off duplicate checks".