Skip to content

fix: disable duplicate checks when threshold <= 0 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
43081j merged 1 commit into from
Jul 3, 2026
Merged

fix: disable duplicate checks when threshold <= 0 #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions build/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25085,13 +25085,15 @@ async function analyzeAndComment() {
info(`Pack size threshold set to ${formatBytes(packSizeThreshold)}`);
const messages = [];
scanForDependencyCount(messages, dependencyThreshold, currentDeps, baseDeps);
scanForDuplicates(
messages,
duplicateThreshold,
currentDeps,
lockfilePath,
parsedCurrentLock
);
if (duplicateThreshold > 0) {
scanForDuplicates(
messages,
duplicateThreshold,
currentDeps,
lockfilePath,
parsedCurrentLock
);
}
await scanForDependencySize(
messages,
sizeThreshold,
Expand Down
17 changes: 10 additions & 7 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,16 @@ async function analyzeAndComment(): Promise<void> {
const messages: string[] = [];

scanForDependencyCount(messages, dependencyThreshold, currentDeps, baseDeps);
scanForDuplicates(
messages,
duplicateThreshold,
currentDeps,
lockfilePath,
parsedCurrentLock
);

if (duplicateThreshold > 0) {
scanForDuplicates(
messages,
duplicateThreshold,
currentDeps,
lockfilePath,
parsedCurrentLock
);
}

await scanForDependencySize(
messages,
Expand Down