-
-
Notifications
You must be signed in to change notification settings - Fork 10
Expand file tree
/
Copy pathprefer-flatmap-over-map-flat.ts
More file actions
87 lines (82 loc) · 2.62 KB
/
Copy pathprefer-flatmap-over-map-flat.ts
File metadata and controls
87 lines (82 loc) · 2.62 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
import type {Rule} from 'eslint';
import type {CallExpression, MemberExpression} from 'estree';
function isMemberCall(
node: CallExpression,
name: string
): node is CallExpression & {
callee: MemberExpression;
} {
return (
node.callee.type === 'MemberExpression' &&
!node.callee.computed &&
node.callee.property.type === 'Identifier' &&
node.callee.property.name === name
);
}
export const preferFlatMapOverMapFlat: Rule.RuleModule = {
meta: {
type: 'suggestion',
docs: {
description:
'Prefer Array.prototype.flatMap() over .map(fn).flat() to avoid the intermediate array',
recommended: false
},
fixable: 'code',
schema: [],
messages: {
preferFlatMap:
'Use `.flatMap(fn)` instead of `.map(fn).flat()` — skips the intermediate array.'
}
},
create(context) {
const {sourceCode} = context;
return {
CallExpression(node: CallExpression) {
// outer .flat()
if (!isMemberCall(node, 'flat')) return;
// .flat() must take no argument or `1` (the default depth)
if (node.arguments.length > 1) return;
if (node.arguments.length === 1) {
const depth = node.arguments[0]!;
if (
depth.type !== 'Literal' ||
typeof depth.value !== 'number' ||
depth.value !== 1
)
return;
}
const inner = node.callee.object;
if (inner.type !== 'CallExpression') return;
if (!isMemberCall(inner, 'map')) return;
// .map must have exactly one argument (the mapper)
if (inner.arguments.length !== 1) return;
const mapperArg = inner.arguments[0]!;
if (mapperArg.type === 'SpreadElement') return;
context.report({
node,
messageId: 'preferFlatMap',
fix(fixer) {
const mapProperty = inner.callee.property;
const dotToken = sourceCode.getTokenBefore(node.callee.property);
if (!dotToken) return null;
const previousToken = sourceCode.getTokenBefore(dotToken);
const gap = previousToken
? sourceCode.text.slice(
previousToken.range![1],
dotToken.range![0]
)
: '';
const removeStart =
previousToken && gap.includes('\n') && gap.trim() === ''
? previousToken.range![1]
: dotToken.range![0];
return [
fixer.replaceText(mapProperty, 'flatMap'),
fixer.removeRange([removeStart, node.range![1]])
];
}
});
}
};
}
};