chore: pr feedback

Author: 43081j

src/rules/prefer-slice-over-split-index.ts

@@ -1,7 +1,6 @@
 import type {
   CallExpression,
   Expression,
-  Literal,
   MemberExpression,
   SpreadElement
 } from 'estree';
@@ -24,7 +23,7 @@ function isSupportedLimit(
 ): boolean {
   if (!limit) return true;
   if (limit.type !== 'Literal') return false;
-  const {value} = limit as Literal;
+  const {value} = limit;
   return typeof value === 'number' && Number.isInteger(value) && value > index;
 }
 
@@ -54,9 +53,9 @@ export const preferSliceOverSplitIndex: Rule.RuleModule = {
     schema: [],
     messages: {
       preferSliceFirst:
-        'Prefer indexOf()+slice() over split(separator)[0] for string separators; split allocates an intermediate array. Preserve the missing-separator fallback explicitly.',
+        'Prefer `indexOf(needle)` and `slice(0, index)` over `split(needle)[0]` for string separators. `split` will allocate an intermediate array, resulting in poorer performance. Preserve the missing-separator fallback explicitly.',
       preferSliceSecond:
-        'Prefer indexOf()+slice() over split(separator)[1] for string separators; split allocates an intermediate array. Preserve missing and repeated-separator behavior explicitly.'
+        'Prefer `indexOf(needle)` and `slice(index)` over `split(needle)[1]` for string separators. `split` will allocate an intermediate array, resulting in poorer performance. Preserve the missing-separator fallback explicitly.'
     }
   },
   create(context) {