Skip to content

fix: use fs/promises for fs.rm #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 1 commit into from
May 30, 2026
Merged

fix: use fs/promises for fs.rm #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifests/native.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,8 +1579,8 @@
"fs.rm": {
"id": "fs.rm",
Comment on lines 1579 to 1580

@ghostdevv ghostdevv May 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably also change this to fs.promises.rm for consistency - otherwise LGTM

@Netail Netail May 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the other replacement entry in the preferred list?

@ghostdevv ghostdevv May 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea if it's not too much 😄

@43081j 43081j May 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth noting no other entry has .promises in its ID yet, even the ones which are from node:fs/promises.

but technically you're probably right in case we ever had fs.rm (sync) in here for whatever reason

@ghostdevv ghostdevv May 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shit sorry Roman I accidentally deleted your comment while trying to negotiate with GitHub - what I was trying to say was let's do this in a follow up 😄

@ghostdevv ghostdevv May 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#687

"type": "native",
"url": {"type": "node", "id": "api/fs.html#fsrmpath-options-callback"},
"nodeFeatureId": {"moduleName": "fs", "exportName": "rm"}
"url": {"type": "node", "id": "api/fs.html#fspromisesrmpath-options"},
"nodeFeatureId": {"moduleName": "node:fs/promises", "exportName": "rm"}
},
"fsPromises": {
"id": "fsPromises",
Expand Down