fix: address PR review comments for Volume SDK

- Re-export VolumeInfo from API schema types instead of custom definitions
- Add res.data undefined check in Volume.create()
- Remove readonly cast hack, use optional name constructor param
- Fix vol implicit any type in Volume.list() (CI error)
- Throw NotFoundError on 404 in Volume.destroy()
- Simplify volumeMounts type to only require name (not volumeId)
- Remove ternary undefined check for volumeMounts
- Move SandboxVolumeMount import to top-level (not inline)
- Change AsyncVolume/Volume → VolumeInfo in volume_mounts type annotations
- Fix volume_mounts type to List[SandboxVolumeMount]
- Export SandboxVolumeMount from package

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: mishushakov

packages/js-sdk/src/sandbox/sandboxApi.ts

@@ -138,7 +138,7 @@ export interface SandboxOpts extends ConnectionOpts {
    *
    * @default undefined
    */
-  volumeMounts?: Record<string, { volumeId: string; name: string } | string>
+  volumeMounts?: Record<string, { name: string } | string>
 
   /**
    * Sandbox URL. Used for local development
@@ -559,12 +559,12 @@ export class SandboxApi {
         secure: opts?.secure ?? true,
         allow_internet_access: opts?.allowInternetAccess ?? true,
         network: opts?.network,
-        volumeMounts: opts?.volumeMounts
-          ? Object.entries(opts.volumeMounts).map(([mountPath, vol]) => ({
-              name: typeof vol === 'string' ? vol : vol.name,
-              path: mountPath,
-            }))
-          : undefined,
+        volumeMounts: Object.entries(opts?.volumeMounts ?? {}).map(
+          ([mountPath, vol]) => ({
+            name: typeof vol === 'string' ? vol : vol.name,
+            path: mountPath,
+          })
+        ),
       },
       signal: config.getSignal(opts?.requestTimeoutMs),
     })

packages/js-sdk/src/volume.ts

@@ -1,21 +1,11 @@
-import { ApiClient, handleApiError } from './api'
+import { ApiClient, handleApiError, components } from './api'
 import { ConnectionConfig, ConnectionOpts } from './connectionConfig'
 import { NotFoundError } from './errors'
 
 /**
  * Information about a volume.
  */
-export interface VolumeInfo {
-  /**
-   * Volume ID.
-   */
-  volumeId: string
-
-  /**
-   * Volume name.
-   */
-  name: string
-}
+export type VolumeInfo = components['schemas']['Volume']
 
 /**
  * Options for request to the Volume API.
@@ -49,10 +39,11 @@ export class Volume {
    * Create a local Volume instance with no API call.
    *
    * @param volumeId volume ID.
+   * @param name volume name (defaults to volumeId).
    */
-  constructor(volumeId: string) {
+  constructor(volumeId: string, name?: string) {
     this.volumeId = volumeId
-    this.name = volumeId
+    this.name = name ?? volumeId
   }
 
   /**
@@ -79,11 +70,11 @@ export class Volume {
       throw err
     }
 
-    const vol = new Volume(res.data!.id)
-    // Override name with the value returned from the API
-    ;(vol as { name: string }).name = res.data!.name
+    if (!res.data) {
+      throw new Error('Body of the response is empty')
+    }
 
-    return vol
+    return new Volume(res.data.id, res.data.name)
   }
 
   /**
@@ -119,10 +110,7 @@ export class Volume {
       throw err
     }
 
-    return {
-      volumeId: res.data!.id,
-      name: res.data!.name,
-    }
+    return res.data!
   }
 
   /**
@@ -145,10 +133,7 @@ export class Volume {
       throw err
     }
 
-    return (res.data ?? []).map((vol) => ({
-      volumeId: vol.id,
-      name: vol.name,
-    }))
+    return res.data ?? []
   }
 
   /**
@@ -171,7 +156,7 @@ export class Volume {
     })
 
     if (res.error?.code === 404) {
-      return
+      throw new NotFoundError(`Volume ${volumeId} not found`)
     }
 
     const err = handleApiError(res)

packages/python-sdk/e2b/__init__.py

@@ -107,6 +107,7 @@
 )
 from .template_async.main import AsyncTemplate
 from .template_sync.main import Template
+from .api.client.models import SandboxVolumeMount
 from .volume_info import VolumeInfo
 from .volume_sync import Volume
 from .volume_async import AsyncVolume
@@ -197,4 +198,5 @@
     "Volume",
     "AsyncVolume",
     "VolumeInfo",
+    "SandboxVolumeMount",
 ]

packages/python-sdk/e2b/sandbox_async/main.py

@@ -2,15 +2,13 @@
 import json
 import logging
 import uuid
-from typing import TYPE_CHECKING, Dict, List, Optional, Union, overload
+from typing import Dict, List, Optional, Union, overload
 
 import httpx
 from packaging.version import Version
 from typing_extensions import Self, Unpack
 
-if TYPE_CHECKING:
-    from e2b.volume_async import AsyncVolume
-
+from e2b.api.client.models import SandboxVolumeMount
 from e2b.api.client.types import Unset
 from e2b.api.client_async import get_transport
 from e2b.connection_config import ApiParams, ConnectionConfig
@@ -20,6 +18,7 @@
 from e2b.sandbox.main import SandboxOpts
 from e2b.sandbox.sandbox_api import McpServer, SandboxMetrics, SandboxNetworkOpts
 from e2b.sandbox.utils import class_method_variant
+from e2b.volume_info import VolumeInfo
 from e2b.sandbox_async.commands.command import Commands
 from e2b.sandbox_async.commands.pty import Pty
 from e2b.sandbox_async.filesystem.filesystem import Filesystem
@@ -165,7 +164,7 @@ async def create(
         allow_internet_access: bool = True,
         mcp: Optional[McpServer] = None,
         network: Optional[SandboxNetworkOpts] = None,
-        volume_mounts: Optional[Dict[str, Union["AsyncVolume", str]]] = None,
+        volume_mounts: Optional[Dict[str, Union[VolumeInfo, str]]] = None,
         **opts: Unpack[ApiParams],
     ) -> Self:
         """
@@ -187,8 +186,6 @@ async def create(
 
         Use this method instead of using the constructor to create a new sandbox.
         """
-        from e2b.api.client.models import SandboxVolumeMount
-
         if not template and mcp is not None:
             template = cls.default_mcp_template
         elif not template:
@@ -545,7 +542,7 @@ async def beta_create(
         secure: bool = True,
         allow_internet_access: bool = True,
         mcp: Optional[McpServer] = None,
-        volume_mounts: Optional[Dict[str, Union["AsyncVolume", str]]] = None,
+        volume_mounts: Optional[Dict[str, Union[VolumeInfo, str]]] = None,
         **opts: Unpack[ApiParams],
     ) -> Self:
         """
@@ -569,8 +566,6 @@ async def beta_create(
 
         Use this method instead of using the constructor to create a new sandbox.
         """
-        from e2b.api.client.models import SandboxVolumeMount
-
         if not template and mcp is not None:
             template = cls.default_mcp_template
         elif not template:
@@ -718,7 +713,7 @@ async def _create(
         secure: bool,
         mcp: Optional[McpServer] = None,
         network: Optional[SandboxNetworkOpts] = None,
-        volume_mounts: Optional[list] = None,
+        volume_mounts: Optional[List[SandboxVolumeMount]] = None,
         **opts: Unpack[ApiParams],
     ) -> Self:
         extra_sandbox_headers = {}

packages/python-sdk/e2b/sandbox_async/sandbox_api.py

@@ -21,6 +21,7 @@
     PostSandboxesSandboxIDTimeoutBody,
     Sandbox,
     SandboxNetworkConfig,
+    SandboxVolumeMount,
 )
 from e2b.api.client.types import UNSET
 from e2b.api.client_async import get_api_client
@@ -159,7 +160,7 @@ async def _create_sandbox(
         secure: bool,
         mcp: Optional[McpServer] = None,
         network: Optional[SandboxNetworkOpts] = None,
-        volume_mounts: Optional[list] = None,
+        volume_mounts: Optional[List[SandboxVolumeMount]] = None,
         **opts: Unpack[ApiParams],
     ) -> SandboxCreateResponse:
         config = ConnectionConfig(**opts)

packages/python-sdk/e2b/sandbox_sync/main.py

@@ -2,15 +2,13 @@
 import json
 import logging
 import uuid
-from typing import TYPE_CHECKING, Dict, List, Optional, Union, overload
+from typing import Dict, List, Optional, Union, overload
 
 import httpx
 from packaging.version import Version
 from typing_extensions import Self, Unpack
 
-if TYPE_CHECKING:
-    from e2b.volume_sync import Volume
-
+from e2b.api.client.models import SandboxVolumeMount
 from e2b.api.client.types import Unset
 from e2b.api.client_sync import get_transport
 from e2b.connection_config import ApiParams, ConnectionConfig
@@ -20,6 +18,7 @@
 from e2b.sandbox.main import SandboxOpts
 from e2b.sandbox.sandbox_api import McpServer, SandboxMetrics, SandboxNetworkOpts
 from e2b.sandbox.utils import class_method_variant
+from e2b.volume_info import VolumeInfo
 from e2b.sandbox_sync.commands.command import Commands
 from e2b.sandbox_sync.commands.pty import Pty
 from e2b.sandbox_sync.filesystem.filesystem import Filesystem
@@ -163,7 +162,7 @@ def create(
         allow_internet_access: bool = True,
         mcp: Optional[McpServer] = None,
         network: Optional[SandboxNetworkOpts] = None,
-        volume_mounts: Optional[Dict[str, Union["Volume", str]]] = None,
+        volume_mounts: Optional[Dict[str, Union[VolumeInfo, str]]] = None,
         **opts: Unpack[ApiParams],
     ) -> Self:
         """
@@ -185,8 +184,6 @@ def create(
 
         Use this method instead of using the constructor to create a new sandbox.
         """
-        from e2b.api.client.models import SandboxVolumeMount
-
         if not template and mcp is not None:
             template = cls.default_mcp_template
         elif not template:
@@ -546,7 +543,7 @@ def beta_create(
         secure: bool = True,
         allow_internet_access: bool = True,
         mcp: Optional[McpServer] = None,
-        volume_mounts: Optional[Dict[str, Union["Volume", str]]] = None,
+        volume_mounts: Optional[Dict[str, Union[VolumeInfo, str]]] = None,
         **opts: Unpack[ApiParams],
     ) -> Self:
         """
@@ -570,8 +567,6 @@ def beta_create(
 
         Use this method instead of using the constructor to create a new sandbox.
         """
-        from e2b.api.client.models import SandboxVolumeMount
-
         if not template and mcp is not None:
             template = cls.default_mcp_template
         elif not template:
@@ -710,7 +705,7 @@ def _create(
         allow_internet_access: bool,
         mcp: Optional[McpServer] = None,
         network: Optional[SandboxNetworkOpts] = None,
-        volume_mounts: Optional[list] = None,
+        volume_mounts: Optional[List[SandboxVolumeMount]] = None,
         **opts: Unpack[ApiParams],
     ) -> Self:
         extra_sandbox_headers = {}

packages/python-sdk/e2b/sandbox_sync/sandbox_api.py

@@ -21,6 +21,7 @@
     PostSandboxesSandboxIDTimeoutBody,
     Sandbox,
     SandboxNetworkConfig,
+    SandboxVolumeMount,
 )
 from e2b.api.client.types import UNSET
 from e2b.connection_config import ApiParams, ConnectionConfig
@@ -158,7 +159,7 @@ def _create_sandbox(
         secure: bool,
         mcp: Optional[McpServer] = None,
         network: Optional[SandboxNetworkOpts] = None,
-        volume_mounts: Optional[list] = None,
+        volume_mounts: Optional[List[SandboxVolumeMount]] = None,
         **opts: Unpack[ApiParams],
     ) -> SandboxCreateResponse:
         config = ConnectionConfig(**opts)

packages/python-sdk/e2b/volume_async.py

@@ -90,7 +90,7 @@ async def get_info(volume_id: str, **opts: Unpack[ApiParams]) -> VolumeInfo:
         if isinstance(res.parsed, Error):
             raise Exception(f"{res.parsed.message}: Request failed")
 
-        return VolumeInfo(volume_id=res.parsed.id, name=res.parsed.name)
+        return res.parsed
 
     @staticmethod
     async def list(**opts: Unpack[ApiParams]) -> List[VolumeInfo]:
@@ -115,7 +115,7 @@ async def list(**opts: Unpack[ApiParams]) -> List[VolumeInfo]:
         if isinstance(res.parsed, Error):
             raise Exception(f"{res.parsed.message}: Request failed")
 
-        return [VolumeInfo(volume_id=v.id, name=v.name) for v in res.parsed]
+        return list(res.parsed)
 
     @staticmethod
     async def destroy(volume_id: str, **opts: Unpack[ApiParams]) -> None:

packages/python-sdk/e2b/volume_info.py

@@ -1,11 +1,3 @@
-from dataclasses import dataclass
+from e2b.api.client.models import Volume as VolumeInfo
 
-
-@dataclass
-class VolumeInfo:
-    """Information about a volume."""
-
-    volume_id: str
-    """Volume ID."""
-    name: str
-    """Volume name."""
+__all__ = ["VolumeInfo"]

packages/python-sdk/e2b/volume_sync.py

@@ -90,7 +90,7 @@ def get_info(volume_id: str, **opts: Unpack[ApiParams]) -> VolumeInfo:
         if isinstance(res.parsed, Error):
             raise Exception(f"{res.parsed.message}: Request failed")
 
-        return VolumeInfo(volume_id=res.parsed.id, name=res.parsed.name)
+        return res.parsed
 
     @staticmethod
     def list(**opts: Unpack[ApiParams]) -> List[VolumeInfo]:
@@ -115,7 +115,7 @@ def list(**opts: Unpack[ApiParams]) -> List[VolumeInfo]:
         if isinstance(res.parsed, Error):
             raise Exception(f"{res.parsed.message}: Request failed")
 
-        return [VolumeInfo(volume_id=v.id, name=v.name) for v in res.parsed]
+        return list(res.parsed)
 
     @staticmethod
     def destroy(volume_id: str, **opts: Unpack[ApiParams]) -> None: