bugbot

Author: mishushakov

packages/js-sdk/src/index.ts

@@ -89,7 +89,6 @@ export type {
   VolumeInfo,
   VolumeEntryStat,
   VolumeFileType,
-  VolumeWriteInfo,
   VolumeMetadataOptions,
   VolumeWriteOptions,
   VolumeRemoveOptions,

packages/js-sdk/src/volume/index.ts

@@ -47,9 +47,9 @@ export class Volume {
    *
    * @param volumeId volume ID.
    */
-  constructor(volumeId: string, name?: string) {
+  constructor(volumeId: string, name: string) {
     this.volumeId = volumeId
-    this.name = name ?? volumeId
+    this.name = name
   }
 
   /**
@@ -511,6 +511,10 @@ export class Volume {
       return new Uint8Array(res.data as ArrayBuffer)
     }
 
+    if (format === 'text') {
+      return res.data?.toString() ?? ''
+    }
+
     return res.data
   }
 
@@ -533,14 +537,12 @@ export class Volume {
     data: string | ArrayBuffer | Blob | ReadableStream<Uint8Array>,
     options?: VolumeWriteOptions,
     opts?: VolumeApiOpts
-  ): Promise<void> {
+  ): Promise<VolumeEntryStat> {
     const config = new ConnectionConfig(opts)
     const client = new ApiClient(config)
 
-    // Convert data to Blob using the same utility as sandbox.files.write
     const blob = await toBlob(data)
 
-    // Use bodySerializer to send binary data with correct Content-Type header
     const res = await client.api.PUT('/volumes/{volumeID}/file', {
       params: {
         path: {
@@ -570,6 +572,14 @@ export class Volume {
     if (err) {
       throw err
     }
+
+    if (!res.data) {
+      throw new Error('Response data is missing')
+    }
+
+    return convertVolumeEntryStat(
+      res.data as components['schemas']['VolumeEntryStat']
+    )
   }
 
   /**
@@ -628,7 +638,6 @@ export class Volume {
 export type {
   VolumeInfo,
   VolumeFileType,
-  VolumeWriteInfo,
   VolumeEntryStat,
   VolumeMetadataOptions,
   VolumeWriteOptions,

packages/js-sdk/src/volume/types.ts

@@ -21,26 +21,6 @@ export type VolumeInfo = {
  */
 export type VolumeFileType = components['schemas']['VolumeEntryStat']['type']
 
-/**
- * Information about a written file.
- */
-export type VolumeWriteInfo = {
-  /**
-   * Name of the filesystem object.
-   */
-  name: string
-
-  /**
-   * Type of the filesystem object.
-   */
-  type?: VolumeFileType
-
-  /**
-   * Path to the filesystem object.
-   */
-  path: string
-}
-
 /**
  * Volume entry stat with dates converted to Date objects.
  */

packages/js-sdk/tests/volume/file.test.ts

@@ -8,9 +8,14 @@ describe('Volume File Operations', () => {
       const path = '/test.txt'
       const content = 'Hello, World!'
 
-      await volume.writeFile(path, content)
-      const readContent = await volume.readFile(path, { format: 'text' })
+      const stat = await volume.writeFile(path, content)
+      expect(stat.name).toBe('test.txt')
+      expect(stat.type).toBe('file')
+      expect(stat.path).toBe(path)
+      expect(stat.mtime).toBeInstanceOf(Date)
+      expect(stat.ctime).toBeInstanceOf(Date)
 
+      const readContent = await volume.readFile(path, { format: 'text' })
       expect(readContent).toBe(content)
     })
 
@@ -73,17 +78,16 @@ describe('Volume File Operations', () => {
         const path = '/metadata.txt'
         const content = 'File with metadata'
 
-        await volume.writeFile(path, content, {
+        const stat = await volume.writeFile(path, content, {
           uid: 1000,
           gid: 1000,
           mode: 0o644,
         })
 
-        const entryInfo = await volume.getInfo(path)
-        expect(entryInfo.type).toBe('file')
-        expect(entryInfo.uid).toBe(1000)
-        expect(entryInfo.gid).toBe(1000)
-        expect(entryInfo.mode).toBe(0o644)
+        expect(stat.type).toBe('file')
+        expect(stat.uid).toBe(1000)
+        expect(stat.gid).toBe(1000)
+        expect(stat.mode).toBe(0o644)
       }
     )
 

packages/python-sdk/e2b/__init__.py

@@ -120,7 +120,6 @@
     VolumeInfo,
     VolumeEntryStat,
     VolumeFileType,
-    VolumeWriteInfo,
     VolumeMetadataOptions,
     VolumeWriteOptions,
     VolumeRemoveOptions,
@@ -222,7 +221,6 @@
     "VolumeInfo",
     "VolumeEntryStat",
     "VolumeFileType",
-    "VolumeWriteInfo",
     "VolumeMetadataOptions",
     "VolumeWriteOptions",
     "VolumeRemoveOptions",

packages/python-sdk/e2b/volume/types.py

@@ -44,17 +44,6 @@ class VolumeEntryStat:
     """Target path for symlinks."""
 
 
-class VolumeWriteInfo(TypedDict, total=False):
-    """Information about a written file."""
-
-    name: str
-    """Name of the filesystem object."""
-    type: Optional[VolumeFileType]
-    """Type of the filesystem object."""
-    path: str
-    """Path to the filesystem object."""
-
-
 class VolumeMetadataOptions(TypedDict, total=False):
     """Options for updating file metadata."""
 
@@ -82,7 +71,6 @@ class VolumeRemoveOptions(TypedDict, total=False):
 
 __all__ = [
     "VolumeInfo",
-    "VolumeWriteInfo",
     "VolumeEntryStat",
     "VolumeFileType",
     "VolumeMetadataOptions",

packages/python-sdk/e2b/volume/volume_async.py

@@ -468,7 +468,7 @@ async def write_file(
         mode: Optional[int] = None,
         force: Optional[bool] = None,
         **opts: Unpack[ApiParams],
-    ) -> None:
+    ) -> VolumeEntryStat:
         """
         Write content to a file.
 
@@ -482,11 +482,12 @@ async def write_file(
         :param mode: Mode of the created file
         :param force: Force overwrite of an existing file
         :param opts: Connection options
+
+        :return: Information about the written file
         """
         config = ConnectionConfig(**opts)
         api_client = get_api_client(config)
 
-        # Convert data to bytes
         if isinstance(data, str):
             data_bytes = data.encode("utf-8")
         elif isinstance(data, bytes):
@@ -533,6 +534,9 @@ async def write_file(
             if err:
                 raise err
 
+        parsed = VolumeEntryStatApi.from_dict(response.json())
+        return _convert_volume_entry_stat(parsed)
+
     async def remove(
         self,
         path: str,

packages/python-sdk/e2b/volume/volume_sync.py

@@ -466,7 +466,7 @@ def write_file(
         mode: Optional[int] = None,
         force: Optional[bool] = None,
         **opts: Unpack[ApiParams],
-    ) -> None:
+    ) -> VolumeEntryStat:
         """
         Write content to a file.
 
@@ -480,11 +480,12 @@ def write_file(
         :param mode: Mode of the created file
         :param force: Force overwrite of an existing file
         :param opts: Connection options
+
+        :return: Information about the written file
         """
         config = ConnectionConfig(**opts)
         api_client = get_api_client(config)
 
-        # Convert data to bytes
         if isinstance(data, str):
             data_bytes = data.encode("utf-8")
         elif isinstance(data, bytes):
@@ -531,6 +532,9 @@ def write_file(
             if err:
                 raise err
 
+        parsed = VolumeEntryStatApi.from_dict(response.json())
+        return _convert_volume_entry_stat(parsed)
+
     def remove(
         self,
         path: str,