Skip to content

Commit edc01f5

Browse files
committed
address PR bots comments
1 parent 23276e0 commit edc01f5

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/pkg_artifacts.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,9 @@ jobs:
4040
pnpm config set exclude-links-from-lockfile true
4141
4242
- name: Sanitize branch name
43+
env:
44+
BRANCH: ${{ github.head_ref }}
4345
run: |
44-
BRANCH="${{ github.head_ref }}"
4546
echo "BRANCH_ID=$(echo "$BRANCH" | sed 's/[^0-9A-Za-z-]/-/g')" >> "$GITHUB_ENV"
4647
4748
- name: Install dependencies

.github/workflows/publish_candidates.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ jobs:
8585
if: ${{ inputs.python-sdk }}
8686
working-directory: packages/python-sdk
8787
run: |
88-
poetry version prerelease
88+
BASE_VERSION=$(poetry version -s)
89+
poetry version "${BASE_VERSION}rc${{ github.run_number }}"
8990
poetry build
9091
poetry config pypi-token.pypi ${PYPI_TOKEN} && poetry publish --skip-existing
9192
env:
@@ -99,7 +100,7 @@ jobs:
99100
if: ${{ inputs.js-sdk }}
100101
working-directory: packages/js-sdk
101102
run: |
102-
npm version prerelease --preid=${{ inputs.preid }}
103+
npm version prerelease --preid=${{ inputs.preid }}.${{ github.run_number }} --no-git-tag-version
103104
npm publish --tag ${{ inputs.tag }} --provenance
104105
105106
- name: Reinstall dependencies
@@ -110,5 +111,5 @@ jobs:
110111
if: ${{ inputs.cli }}
111112
working-directory: packages/cli
112113
run: |
113-
npm version prerelease --preid=${{ inputs.preid }}
114+
npm version prerelease --preid=${{ inputs.preid }}.${{ github.run_number }} --no-git-tag-version
114115
npm publish --tag ${{ inputs.tag }} --provenance

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ jobs:
206206
rc-publish:
207207
name: Publish RC
208208
needs: [rc-validate, rc-python-tests, rc-js-tests, rc-cli-tests]
209-
if: (!cancelled()) && !contains(needs.*.result, 'failure')
209+
if: (!cancelled()) && !contains(needs.*.result, 'failure') && needs.rc-validate.result == 'success'
210210
uses: ./.github/workflows/publish_candidates.yml
211211
with:
212212
js-sdk: ${{ github.event.inputs.js-sdk == 'true' }}

0 commit comments

Comments
 (0)