feat: add GET /templates/{templateID}/tags to JS and Python SDKs#1131
Closed
feat: add GET /templates/{templateID}/tags to JS and Python SDKs#1131
Conversation
Add support for listing all tags for a template, matching the existing infra API endpoint. Includes OpenAPI spec update, regenerated clients, SDK methods, types, and unit tests for both SDKs.
beran-t
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
🦋 Changeset detectedLatest commit: d4a325a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Only keep the two new generated files needed for get_tags: - get_templates_template_id_tags.py - template_tag.py
- Add explicit type for `item` parameter in getTemplateTags .map() to fix TS7006 error in CLI build - Rewrite generated Python files to match CI's openapi-python-client output style (Union/Optional syntax, f-strings, no __future__ import)
Contributor
Author
|
Replaced by a clean PR from a branch based on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /templates/{templateID}/tagsendpoint to the OpenAPI spec withTemplateTagschema (tag,buildID,createdAt)Template.getTags(templateId)to the JS/TS SDK andTemplate.get_tags(template_id)/AsyncTemplate.get_tags(template_id)to the Python SDK