fix: increase timeout for backgroundBuild test#1168
Closed
dobrac wants to merge 1 commit into
Closed
Conversation
The buildInBackground test was failing with a 10 second timeout. The test makes multiple sequential API calls (create template, get file upload links, trigger build) before returning, which exceeds the 10 second budget. Removed the explicit timeout override so the test inherits the workspace default of 180 seconds.
|
Contributor
Package ArtifactsBuilt from 579e728. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.13.1-dobrac-fix-bg-build-test.0.tgzCLI ( npm install ./e2b-cli-2.7.3-dobrac-fix-bg-build-test.0.tgzPython SDK ( pip install ./e2b-2.14.0+dobrac.fix.bg.build.test-py3-none-any.whl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buildInBackground test was timing out with a 10 second limit. The
buildInBackgroundmethod makes multiple sequential API calls (create template, get file upload links, trigger build) before returning, which exceeds the tight 10 second budget. Removed the explicit timeout override so the test inherits the workspace default of 180 seconds, which is appropriate for integration tests.Note
Low Risk
Low risk: only changes a Vitest integration test timeout behavior to avoid flaky failures; no production logic is modified.
Overview
Removes the explicit
10_000ms timeout override frombackgroundBuild.test.tsso thebuild template in backgroundtest can use the suite/workspace default timeout (reducing flakiness from slow sequential API calls inTemplate.buildInBackground).Written by Cursor Bugbot for commit e945a4d. This will update automatically on new commits. Configure here.