fix: update kill test to use valid sandbox ID format#1169
Merged
Conversation
The infra now validates sandbox ID format (^[a-z0-9]+$). Replace 'non-existing-sandbox' (invalid due to hyphens) with 'nonexistingsandbox' so the test passes format validation and hits the expected 404 path.
dobrac
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
|
Contributor
Package ArtifactsBuilt from 8cb48ea. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.13.1-dobrac-fix-kill-test-sandbox-id.0.tgzCLI ( npm install ./e2b-cli-2.7.3-dobrac-fix-kill-test-sandbox-id.0.tgzPython SDK ( pip install ./e2b-2.14.0+dobrac.fix.kill.test.sandbox.id-py3-none-any.whl |
jakubno
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The infra now validates sandbox ID format (^[a-z0-9]+$), allowing only lowercase alphanumeric characters. The test was using 'non-existing-sandbox' which fails format validation due to hyphens, returning a 400 error instead of reaching the expected 404 path.
This updates the test to use 'nonexistingsandbox' — a valid format that doesn't exist, so it properly hits the 404 "not found" response and returns false as expected.
Note
Low Risk
Low risk: test-only change that updates hardcoded IDs to match new validation rules, without modifying runtime logic.
Overview
Updates JS and Python SDK
kill non-existing sandboxtests to use a lowercase alphanumeric sandbox ID (nonexistingsandbox) instead of a hyphenated one, so the tests exercise the intended not-found path rather than failing format validation.Written by Cursor Bugbot for commit e43acb6. This will update automatically on new commits. Configure here.