Limit hanging stream timeout#1197
Conversation
🦋 Changeset detectedLatest commit: e66ef8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Package ArtifactsBuilt from bb9ae51. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.14.2-stream-hang-timeout.0.tgzCLI ( npm install ./e2b-cli-2.8.2-stream-hang-timeout.0.tgzPython SDK ( pip install ./e2b-2.15.2+stream.hang.timeout-py3-none-any.whl |
Package ArtifactsBuilt from 7175dc0. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.14.2-stream-hang-timeout.0.tgzCLI ( npm install ./e2b-cli-2.8.2-stream-hang-timeout.0.tgzPython SDK ( pip install ./e2b-2.15.2+stream.hang.timeout-py3-none-any.whl |
…into stream-hang-timeout
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4d0fa580c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if request_timeout is not None: | ||
| timeout_ext["connect"] = request_timeout | ||
| timeout_ext["pool"] = request_timeout | ||
| timeout_ext["write"] = request_timeout |
There was a problem hiding this comment.
This write timeout should be how long the "write" to the server we do can take. It should be minimal, as it is not streamed.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
matthewlouisbrockman
left a comment
matthewlouisbrockman
left a comment
There was a problem hiding this comment.
makes sense, using the timeout for all the timeouts you can have.
|
add a changeset pls |
4 participants
Note
Medium Risk
Changes request timeout semantics for server-stream calls by adding
writeand conditionalreadtimeouts, which could alter behavior for long-running/slow streams but is limited to client-side networking configuration.Overview
Improves timeout handling for server-stream requests in the Python SDK.
Client._prepare_server_stream_requestnow builds a richerhttpcoretimeout extension:request_timeoutapplies toconnect,pool, andwrite, and the separatetimeoutparameter is mapped to areadtimeout (to help prevent hanging streams).Adds a changeset to publish a patch release documenting the updated
request_timeoutbehavior.Written by Cursor Bugbot for commit e66ef8e. This will update automatically on new commits. Configure here.