Skip to content

feat(cli): fully deprecate template build command (v1)#1390

Open
mishushakov wants to merge 6 commits into
mainfrom
mishushakov/deprecate-template-build-cmd
Open

feat(cli): fully deprecate template build command (v1)#1390
mishushakov wants to merge 6 commits into
mainfrom
mishushakov/deprecate-template-build-cmd

Conversation

@mishushakov
Copy link
Copy Markdown
Member

@mishushakov mishushakov commented Jun 5, 2026

Summary

  • Strips all v1 build logic from `e2b template build` (`bd`): Docker build/push, API calls, config-loading, and retry/proxy handling are removed
  • The command now only displays the existing yellow deprecation warning (pointing to the v2 migration guide) and exits with code 1
  • Deletes `buildWithProxy.ts` which is no longer referenced anywhere
  • Moves `getDockerfile` helper (used by `template create` and `template migrate`) to a new shared `dockerfile.ts` module, leaving `build.ts` as a clean stub

Test plan

  • Run `e2b template build` — confirm deprecation warning is shown and the command exits immediately
  • Run `e2b template create` and `e2b template migrate` — confirm they still work (both use the moved `getDockerfile` helper)

🤖 Generated with Claude Code

Remove all v1 build system logic from `e2b template build`; the command now only displays the deprecation warning and exits. Delete the unused buildWithProxy.ts. The `getDockerfile` helper is retained for use by `create` and `migrate` commands.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 5, 2026

PR Summary

Medium Risk
Breaking CLI behavior for anyone still relying on v1 template build; v2 create/migrate paths are unchanged aside from the shared helper move.

Overview
e2b template build (bd) no longer runs the v1 Docker/API flow; it only prints the v2 migration deprecation box and exits with code 1. buildWithProxy.ts is removed and unused deps (command-exists, strip-ansi) are dropped from @e2b/cli.

getDockerfile moves to dockerfile.ts; template create and template migrate import it from there. Root help and README now point at e2b template create instead of template build.

Scripts or docs that still call e2b template build expecting a real build will fail until they switch to e2b template create or the v2 migration path.

Reviewed by Cursor Bugbot for commit fa5b8a8. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 5, 2026

🦋 Changeset detected

Latest commit: fa5b8a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@e2b/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Package Artifacts

Built from eb5211b. Download artifacts from this workflow run.

JS SDK (e2b@2.27.2-mishushakov-deprecate-template-build-cmd.0):

npm install ./e2b-2.27.2-mishushakov-deprecate-template-build-cmd.0.tgz

CLI (@e2b/cli@2.10.4-mishushakov-deprecate-template-build-cmd.0):

npm install ./e2b-cli-2.10.4-mishushakov-deprecate-template-build-cmd.0.tgz

Python SDK (e2b==2.25.1+mishushakov-deprecate-template-build-cmd):

pip install ./e2b-2.25.1+mishushakov.deprecate.template.build.cmd-py3-none-any.whl

mishushakov and others added 3 commits June 5, 2026 18:01
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… stub

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment thread packages/cli/src/commands/template/build.ts
Comment thread packages/cli/src/commands/template/build.ts
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48a5dc9679

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .changeset/deprecate-template-build-cmd.md
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant