Skip to content

Add filtering option for listing sandboxes#532

Merged
mishushakov merged 10 commits intomainfrom
implement-server-side-sandbox-metadata-lookup-e2b-1421
Mar 21, 2025
Merged

Add filtering option for listing sandboxes#532
mishushakov merged 10 commits intomainfrom
implement-server-side-sandbox-metadata-lookup-e2b-1421

Conversation

@jakubno
Copy link
Copy Markdown
Member

@jakubno jakubno commented Jan 10, 2025

Description

Allow users to filter out sandbox based on metadata

@jakubno jakubno added sdk Improvements or additions to SDKs Improvement Improvement for current functionality labels Jan 10, 2025
@jakubno jakubno requested a review from ValentaTomas as a code owner January 10, 2025 14:03
@linear
Copy link
Copy Markdown

linear bot commented Jan 10, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 505a53f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@e2b/python-sdk Patch
e2b Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ValentaTomas
Copy link
Copy Markdown
Member

(Blocked by e2b-dev/infra#235 right now.)

@jakubno jakubno force-pushed the implement-server-side-sandbox-metadata-lookup-e2b-1421 branch from 6d972dc to d5e2aea Compare January 17, 2025 20:52
@ValentaTomas ValentaTomas changed the base branch from main to filtering-sandboxes-state March 15, 2025 06:41
@ValentaTomas ValentaTomas changed the base branch from filtering-sandboxes-state to main March 15, 2025 06:42
@jakubno jakubno force-pushed the implement-server-side-sandbox-metadata-lookup-e2b-1421 branch from 6f3a2ae to 16f03d1 Compare March 18, 2025 10:04
@mishushakov
Copy link
Copy Markdown
Member

the only confusing part i find is that you call it "filters" instead of "metadata"

@mlejva
Copy link
Copy Markdown
Member

mlejva commented Mar 18, 2025

This looks like it's missing updates to docs. Please add it.

@jakubno
Copy link
Copy Markdown
Member Author

jakubno commented Mar 18, 2025

They are already here https://e2b.dev/docs/sandbox/list#filtering-sandboxes

@jakubno jakubno requested a review from mlejva as a code owner March 20, 2025 12:55
Copy link
Copy Markdown
Member

@mishushakov mishushakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the DX supposed to be like

Sandbox.list({ query: {metadata: {'a': 'b'}}})

Right now it is

Sandbox.list({metadata: {'a': 'b'}})

Also, there should be updates to the (beta?) docs, since this is now changed

Comment thread packages/js-sdk/src/sandbox/sandboxApi.ts
Comment thread packages/python-sdk/e2b/sandbox_async/sandbox_api.py Outdated
@mlejva
Copy link
Copy Markdown
Member

mlejva commented Mar 20, 2025

Explicitly confirming what Mish said, it should be:

Sandbox.list({ query: {metadata: {'a': 'b'}}})

and similarly in Python

@mishushakov mishushakov merged commit 5c4d075 into main Mar 21, 2025
5 checks passed
@mishushakov mishushakov deleted the implement-server-side-sandbox-metadata-lookup-e2b-1421 branch March 21, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Improvement for current functionality sdk Improvements or additions to SDKs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants