Add getInfo/get_info methods to the SDKs#625
Conversation
🦋 Changeset detectedLatest commit: 654ac8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ValentaTomas
requested review from
dobrac and
mlejva
and removed request for
jakubno and
mlejva
dobrac
left a comment
dobrac
left a comment
There was a problem hiding this comment.
looks good, just minor documentation comments improvements
| ...(res.data.alias && { name: res.data.alias }), | ||
| metadata: res.data.metadata ?? {}, | ||
| startedAt: new Date(res.data.startedAt), | ||
| endAt: new Date(res.data.endAt), |
There was a problem hiding this comment.
what if the sandbox is still running? It it the expected end time then? It might be good to explain in then in the documentation as it isn't clear imo
There was a problem hiding this comment.
It's returned from the API already, should be the timestamp when the sandbox is expected to expire
| await wait(6000) | ||
|
|
||
| await sandbox.isRunning() | ||
| expect(await sandbox.isRunning()).toBeTruthy() |
There was a problem hiding this comment.
before, I believe the test would pass even if the promise resolved with false, it should however check that the Promise resolves with true, explicitly
mishushakov
dismissed
mlejva’s stale review
I have addressed the comments and @dobrac has approved already
5 participants
getInfo/get_infomethods to the SDKs #517