Skip to content

Allow python SDKs to write any instance of IOBase files#640

Merged
0div merged 3 commits intomainfrom
sandboxfileswrite-cannot-upload-binary-files-e2b-1891
Mar 26, 2025
Merged

Allow python SDKs to write any instance of IOBase files#640
0div merged 3 commits intomainfrom
sandboxfileswrite-cannot-upload-binary-files-e2b-1891

Conversation

@0div
Copy link
Copy Markdown
Contributor

@0div 0div commented Mar 25, 2025

  • update write method in sync & async python SDKs to allow io.BufferedReader files
  • update tests

@0div 0div added the bug Something isn't working label Mar 25, 2025
@0div 0div self-assigned this Mar 25, 2025
@linear
Copy link
Copy Markdown

linear bot commented Mar 25, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: 5a208eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@e2b/python-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@0div 0div marked this pull request as ready for review March 25, 2025 21:43
@0div 0div changed the title Allow writing BufferedReader Allow python SDKs to write BufferedReader files Mar 25, 2025
Comment thread packages/python-sdk/e2b/sandbox_sync/filesystem/filesystem.py Outdated
Comment thread packages/python-sdk/tests/async/sandbox_async/files/test_write.py Outdated
@0div 0div requested a review from ValentaTomas March 25, 2025 22:56
@0div 0div changed the title Allow python SDKs to write BufferedReader files Allow python SDKs to write any instance of IOBase files Mar 25, 2025
@jakubno
Copy link
Copy Markdown
Member

jakubno commented Mar 26, 2025

Add changeset before merging

@0div 0div merged commit c865121 into main Mar 26, 2025
5 checks passed
@0div 0div deleted the sandboxfileswrite-cannot-upload-binary-files-e2b-1891 branch March 26, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants