Pre-load JavaScript kernel into memory for faster JS startup#139
Merged
mishushakov merged 3 commits intomainfrom Aug 20, 2025
Merged
Conversation
There was a problem hiding this comment.
Bug: WebSocket Cleanup Fails on Initialization Error
A resource leak occurs if javascript_context creation fails. The python_context websocket, which was successfully created, is not cleaned up because the cleanup logic after yield is not reached when an exception occurs during initialization.
template/server/main.py#L37-L54
code-interpreter/template/server/main.py
Lines 37 to 54 in 38b491d
Comment @cursor review or bugbot run to trigger another review on this PR
Member
Author
|
I will be doing another PR for what Cursor said (although can be ignored) |
Member
Author
|
Currently blocked by |
jakubno
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks
Execution time
Before:
Python kernel time taken: 64.61 milliseconds
JavaScript kernel time taken: 256.47 milliseconds
After:
Python kernel time taken: 64.32 milliseconds
JavaScript kernel time taken: 67.80 milliseconds
Memory usage
Before/after loading JavaScript kernel into memory (idle)