Moved configuration files to /root (as legacy) and mimic user setup in Docker#171
Moved configuration files to /root (as legacy) and mimic user setup in Docker#171mishushakov merged 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
code-interpreter/template/build_ci.py
Lines 5 to 6 in 4eff6e9
The commit renamed make_template’s set_user_workdir flag to is_docker, but build_ci.py still calls make_template(set_user_workdir=True). That call now raises TypeError: make_template() got an unexpected keyword argument 'set_user_workdir' whenever the CI build script runs, so the CI template build will fail. Update the invocation to use the new signature or drop the flag.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dobrac
left a comment
There was a problem hiding this comment.
Just double check please the template still builds correctly with the old build system using the Docker image
Note
Moves config/workdir to /root, adds Docker user creation with sudo, updates startup paths, and adjusts build scripts/resources.
template/template.py):/rootand config envs to/root/.jupyter,/root/.ipython,/root/.server.set_user_workdirwithis_dockerflag that createsuser, home dir, and grants passwordless sudo.userand set workdir to/home/userbefore start.sudo /root/.jupyter/start-up.sh.template/start-up.sh):/root/.server/andMATPLOTLIBRC=/root/.config/matplotlib/.matplotlibrcpaths.build_ci.py,build_prod.py: callmake_template()withoutset_user_workdir.build_docker.py: callmake_template(..., is_docker=True).build_test.py: removeset_user_workdir; increasecpu_countto2andmemory_mbto2048.Written by Cursor Bugbot for commit 2e068f1. This will update automatically on new commits. Configure here.