refactor: replace EditSecretDialog with UpdateWebhookSecretDialog for enhanced secret management

- Replaced the EditSecretDialog component with the new UpdateWebhookSecretDialog to improve the user experience when updating webhook secrets.
- Updated the WebhookRowActions to reflect this change, ensuring consistent functionality across the application.
- Introduced a new dialog that provides better feedback and validation for secret updates, enhancing usability.

These changes aim to streamline the process of managing webhook secrets and improve user interaction with the dialogs.

Author: sarimrmalik

src/features/dashboard/settings/webhooks/table-row.tsx

@@ -34,8 +34,8 @@ import { useDashboard } from '../../context'
 import { UserAvatar } from '../../shared'
 import { WEBHOOK_EVENT_LABELS } from './constants'
 import { DeleteWebhookDialog } from './delete-webhook-dialog'
-import { EditSecretDialog } from './edit-secret-dialog'
 import type { Webhook } from './types'
+import { UpdateWebhookSecretDialog } from './update-webhook-secret-dialog'
 import { UpsertWebhookDialog } from './upsert-webhook-dialog'
 
 type WebhookRowProps = {
@@ -174,11 +174,11 @@ const WebhookRowActions = ({ webhook }: WebhookRowActionsProps) => {
               Delete
             </DropdownMenuItem>
           </DeleteWebhookDialog>
-          <EditSecretDialog webhook={webhook}>
+          <UpdateWebhookSecretDialog webhook={webhook}>
             <DropdownMenuItem inset onSelect={(e) => e.preventDefault()}>
               <PrivateIcon className={actionIconClassName} /> Edit secret
             </DropdownMenuItem>
-          </EditSecretDialog>
+          </UpdateWebhookSecretDialog>
         </DropdownMenuGroup>
       </DropdownMenuContent>
     </DropdownMenu>

…settings/webhooks/edit-secret-dialog.tsx …ebhooks/update-webhook-secret-dialog.tsxsrc/features/dashboard/settings/webhooks/edit-secret-dialog.tsx renamed to src/features/dashboard/settings/webhooks/update-webhook-secret-dialog.tsx src/features/dashboard/settings/webhooks/edit-secret-dialog.tsx renamed to src/features/dashboard/settings/webhooks/update-webhook-secret-dialog.tsx

@@ -37,15 +37,15 @@ import { Input } from '@/ui/primitives/input'
 import { Loader } from '@/ui/primitives/loader'
 import type { Webhook } from './types'
 
-interface EditSecretDialogProps {
+interface UpdateWebhookSecretDialogProps {
   children: React.ReactNode
   webhook: Webhook
 }
 
-export const EditSecretDialog = ({
+export const UpdateWebhookSecretDialog = ({
   children: trigger,
   webhook,
-}: EditSecretDialogProps) => {
+}: UpdateWebhookSecretDialogProps) => {
   'use no memo'
 
   const { team } = useDashboard()
@@ -74,9 +74,7 @@ export const EditSecretDialog = ({
         handleDialogChange(false)
       },
       onError: (err) => {
-        toast(
-          defaultErrorToast(err.message || 'Failed to edit webhook secret')
-        )
+        toast(defaultErrorToast(err.message || 'Failed to edit webhook secret'))
       },
     })
   )

src/features/dashboard/settings/webhooks/upsert-webhook-dialog.tsx

@@ -132,12 +132,7 @@ export function UpsertWebhookDialog({
   }
 
   const handleDialogChange = (value: boolean) => {
-    if (
-      !value &&
-      isUpdateMode &&
-      hasChanges &&
-      !upsertMutation.isPending
-    ) {
+    if (!value && isUpdateMode && hasChanges && !upsertMutation.isPending) {
       setDiscardConfirmOpen(true)
       return
     }