Skip to content

Commit 374ca7a

Browse files
authored
fix: templates list and builds are missing separators (#468)
Fix: templates list and builds are missing separators | Templates list | Template builds | |--------|--------| | <img width="1083" height="348" alt="templates-list" src="https://github.com/user-attachments/assets/d08b9bf7-654a-42f6-9350-495c0275a3b5" /> | <img width="1266" height="260" alt="templates-builds" src="https://github.com/user-attachments/assets/a5979d3f-d6bb-4ac9-8b00-48d5ef10df59" /> |
1 parent 6aabce8 commit 374ca7a

2 files changed

Lines changed: 17 additions & 2 deletions

File tree

src/features/dashboard/templates/builds/table-body.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export function BuildsTableBody({
5252
key={row.id}
5353
className={cn(
5454
'group/row relative h-10 min-w-full cursor-pointer -mx-2 px-2 hover:bg-bg-1 border-b-0 transition-none w-[calc(100%+16px)]',
55-
'border-stroke/80 hover:z-20 focus-within:z-10',
55+
'hover:z-20 focus-within:z-10',
5656
{ 'bg-bg-1 animate-pulse': isBuilding }
5757
)}
5858
onClick={() => onRowClick(row.original)}
@@ -69,6 +69,13 @@ export function BuildsTableBody({
6969
{flexRender(cell.column.columnDef.cell, cell.getContext())}
7070
</DataTableCell>
7171
))}
72+
<div
73+
aria-hidden
74+
className={cn(
75+
'pointer-events-none absolute inset-x-2 bottom-0 border-b border-stroke/80',
76+
'group-hover/row:hidden group-focus-visible/row:hidden'
77+
)}
78+
/>
7279
<RowHoverFrame />
7380
</DataTableRow>
7481
)

src/features/dashboard/templates/list/table-body.tsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ export function TemplatesTableBody({
139139
isSelected={row.getIsSelected()}
140140
className={cn(
141141
'group/row relative h-8 min-w-full -mx-2 px-2 hover:bg-bg-1 border-b-0 transition-none w-[calc(100%+16px)]',
142-
'border-stroke/80 hover:z-20 focus-within:z-10',
142+
'hover:z-20 focus-within:z-10',
143143
'has-[button[aria-haspopup=menu][data-state=open]]:z-10'
144144
)}
145145
>
@@ -165,6 +165,14 @@ export function TemplatesTableBody({
165165
{flexRender(cell.column.columnDef.cell, cell.getContext())}
166166
</DataTableCell>
167167
))}
168+
<div
169+
aria-hidden
170+
className={cn(
171+
'pointer-events-none absolute inset-x-2 bottom-0 border-b border-stroke/80',
172+
'group-hover/row:hidden group-focus-visible/row:hidden',
173+
'group-has-[button[aria-haspopup=menu][data-state=open]]/row:hidden'
174+
)}
175+
/>
168176
<RowHoverFrame
169177
className={cn(
170178
'group-has-[button[aria-haspopup=menu][data-state=open]]/row:border-stroke',

0 commit comments

Comments
 (0)