fix status priority

Co-authored-by: Jakub Dobry <dobrac@users.noreply.github.com>

Author: cursoragent

src/features/dashboard/layouts/status-indicator.ts

@@ -49,19 +49,32 @@ function hasMaintenanceInProgress(
   maintenances: IncidentIOStatusPageSummaryResponse['scheduled_maintenances']
 ) {
   return maintenances?.some(
-    (maintenance) => maintenance.status === 'maintenance_in_progress'
+    (maintenance) =>
+      maintenance.status === 'in_progress' ||
+      maintenance.status === 'maintenance_in_progress'
   )
 }
 
 export function getStatusPageStateFromSummary(
   data: IncidentIOStatusPageSummaryResponse
 ): AggregateState {
-  if (hasMaintenanceInProgress(data.scheduled_maintenances))
-    return 'maintenance'
+  const indicatorState = stateFromIndicator(data.status?.indicator)
+  const componentState = getWorstComponentState(data.components)
+
+  if (indicatorState === 'downtime' || componentState === 'downtime')
+    return 'downtime'
+
+  if (indicatorState === 'degraded' || componentState === 'degraded')
+    return 'degraded'
 
-  return (
-    stateFromIndicator(data.status?.indicator) ??
-    getWorstComponentState(data.components) ??
-    'unknown'
+  if (
+    indicatorState === 'maintenance' ||
+    componentState === 'maintenance' ||
+    hasMaintenanceInProgress(data.scheduled_maintenances)
   )
+    return 'maintenance'
+
+  if (indicatorState === 'operational') return 'operational'
+
+  return 'unknown'
 }

tests/unit/status-indicator.test.ts

@@ -13,6 +13,18 @@ describe('status-indicator', () => {
   })
 
   it('should report maintenance for in-progress maintenance', () => {
+    expect(
+      getStatusPageStateFromSummary({
+        scheduled_maintenances: [
+          {
+            status: 'in_progress',
+          },
+        ],
+      })
+    ).toBe('maintenance')
+  })
+
+  it('should support incident.io maintenance status naming', () => {
     expect(
       getStatusPageStateFromSummary({
         scheduled_maintenances: [
@@ -24,6 +36,21 @@ describe('status-indicator', () => {
     ).toBe('maintenance')
   })
 
+  it('should prioritize critical indicator over maintenance', () => {
+    expect(
+      getStatusPageStateFromSummary({
+        status: {
+          indicator: 'critical',
+        },
+        scheduled_maintenances: [
+          {
+            status: 'in_progress',
+          },
+        ],
+      })
+    ).toBe('downtime')
+  })
+
   it('should report downtime for critical summary indicator', () => {
     expect(
       getStatusPageStateFromSummary({