Skip to content

chore: remove dead LOKI_* env vars and deduplicate OTEL_SERVICE_NAME#307

Merged
ben-fornefeld merged 1 commit intomainfrom
devin/1777416610-cleanup-dead-env-vars
Apr 28, 2026
Merged

chore: remove dead LOKI_* env vars and deduplicate OTEL_SERVICE_NAME#307
ben-fornefeld merged 1 commit intomainfrom
devin/1777416610-cleanup-dead-env-vars

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Apr 28, 2026

Summary

Cleans up .env.example based on a codebase audit:

  1. Removed dead LOKI_* env vars (LOKI_SERVICE_NAME, LOKI_HOST, LOKI_USERNAME, LOKI_PASSWORD) — these were listed in .env.example but never read anywhere in src/. Only the OTEL vars are in use.

  2. Removed duplicate OTEL_SERVICE_NAME — it appeared at both line 38 (standalone) and line 54 (under the OTEL Configuration section). Kept the single entry under the consolidated OTEL Configuration block.

Notes

This is a .env.example-only change — no application code was modified.

Link to Devin session: https://app.devin.ai/sessions/c654c1eb471d452681b9ba446fcb3269

…in .env.example

Co-Authored-By: ben@e2b.dev <ben@e2b.dev>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Error Error Apr 28, 2026 10:51pm
web-juliett Ready Ready Preview, Comment Apr 28, 2026 10:51pm

Request Review

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward .env.example cleanup, no application code affected.

Extended reasoning...

Overview

This PR only modifies .env.example, removing four LOKI_* variables and a duplicate OTEL_SERVICE_NAME entry. No application code, build configuration, or runtime behavior is affected.

Security risks

None. .env.example is purely documentation/template — it has no effect on deployed environments. Removing references to unused variables cannot leak secrets or change auth behavior.

Level of scrutiny

Minimal. This is a documentation-only change. I verified via grep that no source files reference LOKI_* anywhere in the repository, confirming the audit claim in the PR description. The remaining OTEL block is consistent and properly consolidated.

Other factors

The PR description includes a checklist asking the human to verify deployment configs and CI pipelines don't reference the removed vars — that verification is outside this repo, but since the example file is non-authoritative, even if downstream configs still set those vars, nothing breaks.

@ben-fornefeld ben-fornefeld merged commit 94e8c82 into main Apr 28, 2026
10 of 11 checks passed
@ben-fornefeld ben-fornefeld deleted the devin/1777416610-cleanup-dead-env-vars branch April 28, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant