Skip to content

fix: table empty state layout#337

Merged
ben-fornefeld merged 3 commits into
mainfrom
cursor/c3132bd4
May 21, 2026
Merged

fix: table empty state layout#337
ben-fornefeld merged 3 commits into
mainfrom
cursor/c3132bd4

Conversation

@ben-fornefeld

@ben-fornefeld ben-fornefeld commented May 21, 2026

Copy link
Copy Markdown
Member

Summary

  • restore the shared table empty-state layout so icon and text children render inline without the extra wrapper that caused wrapping

Test plan

  • bunx biome check src/ui/primitives/table.tsx

@cla-bot cla-bot Bot added the cla-signed label May 21, 2026
@vercel

vercel Bot commented May 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment May 21, 2026 2:33am
web-juliett Ready Ready Preview, Comment May 21, 2026 2:33am

Request Review

@cursor

cursor Bot commented May 21, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Small, CSS-only change to empty-state table rendering; low risk beyond minor layout regressions in empty states.

Overview
Adjusts TableEmptyState markup to stop forcing flex layout on the underlying TableRow/TableCell, and prevents the empty-state content from wrapping by adding whitespace-nowrap to the inner message container.

Reviewed by Cursor Bugbot for commit 3a9dab9. Bugbot is set up for automated code reviews on this repo. Configure here.

@ben-fornefeld ben-fornefeld changed the title Fix table empty state layout fix: table empty state layout May 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the TableEmptyState row markup to restore the intended “shared” empty-state layout so the icon + text children render inline (without an extra wrapper that previously contributed to wrapping/layout issues).

Changes:

  • Moves the empty-state typography/layout classes onto the index === 1 row container.
  • Removes the inner wrapper around children and renders children directly for the “content row”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ui/primitives/table.tsx Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4ed4d19. Configure here.

Comment thread src/ui/primitives/table.tsx Outdated
@ben-fornefeld ben-fornefeld merged commit 5fa2cea into main May 21, 2026
15 checks passed
@ben-fornefeld ben-fornefeld deleted the cursor/c3132bd4 branch May 21, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants