fix: make events empty state full width in grid table#339
Merged
ben-fornefeld merged 4 commits intoMay 22, 2026
Conversation
Co-Authored-By: vasek <vasek.mlejnsky@gmail.com>
devin-ai-integration
Bot
requested review from
ben-fornefeld and
drankou
as code owners
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: vasek <vasek.mlejnsky@gmail.com>
Create a dedicated VirtualizedTableEmptyState component that uses the flex min-w-full pattern required by grid-based virtualized tables. This keeps the core TableEmptyState untouched for standard table layouts. Co-Authored-By: vasek <vasek.mlejnsky@gmail.com>
ben-fornefeld
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "No events found" empty state in the sandbox events table was not stretching to full width. The events table uses
display: gridfor virtualization (same as sandbox logs and build logs), but the sharedTableEmptyStatecomponent is designed for standardtable-fixedlayouts wherecolSpanworks natively.Fix: Extracted a new
VirtualizedTableEmptyStatecomponent invirtualized-table-ui.tsxthat uses the sameflex min-w-fullpattern asVirtualizedTableLoaderBodyandVirtualizedTableRow. The coreTableEmptyStateis left untouched so non-virtualized tables (api-keys, invoices, members, webhooks) continue working correctly.Review & Testing Checklist for Human
VirtualizedTableLoaderBody— unchanged)Notes
display: gridon<Table>— this is required for absolute-positioned virtualized rows. Non-virtualized tables use standardtable-fixedlayout.LogsEmptyBody) uses a different visual style (tall centered text) and was not changed.Link to Devin session: https://app.devin.ai/sessions/286135bb1f0e49c0a49cd1512d67be3a
Requested by: @mlejva