Skip to content

fix: make events empty state full width in grid table #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-fornefeld merged 4 commits into from
May 22, 2026
Merged

fix: make events empty state full width in grid table #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51cdb43
fix: make events empty state full width in grid table
devin-ai-integration[bot] May 22, 2026
a7d58b3
Merge branch 'main' into devin/1779425280-fix-events-empty-state-width
ben-fornefeld May 22, 2026
b7490ad
fix: use flex min-w-full pattern for events empty state in grid table
devin-ai-integration[bot] May 22, 2026
deb47c5
refactor: extract VirtualizedTableEmptyState for grid tables
devin-ai-integration[bot] May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/features/dashboard/common/virtualized-table-ui.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { VirtualItem, Virtualizer } from '@tanstack/react-virtual'
import type { CSSProperties, ReactNode } from 'react'
import { Loader } from '@/ui/primitives/loader'
import { TableBody, TableCell, TableRow } from '@/ui/primitives/table'
import { TableEmptyRowBorder } from '@/ui/primitives/table-empty-row-border'

export const getVirtualizedRowStyle = (
virtualRow: VirtualItem,
Expand Down Expand Up @@ -51,3 +52,36 @@ export const VirtualizedTableLoaderBody = () => (
</TableRow>
</TableBody>
)

interface VirtualizedTableEmptyStateProps {
children: ReactNode
}

const EMPTY_STATE_ROWS = Array.from({ length: 3 })

export const VirtualizedTableEmptyState = ({
children,
}: VirtualizedTableEmptyStateProps) => (
<TableBody className="grid">
<TableRow className="flex min-w-full">
<TableCell className="flex-1 p-0">
<div className="w-full gap-2 relative flex flex-col justify-center items-center">
{EMPTY_STATE_ROWS.map((_, index) => (
<div
key={index}
className="h-11 w-full border border-bg-highlight relative flex items-center gap-2 justify-center overflow-hidden"
>
<TableEmptyRowBorder className="absolute bottom-0 left-0 rotate-180 opacity-99" />
<TableEmptyRowBorder className="absolute bottom-0 right-0 opacity-99" />
{index === 1 ? (
<div className="text-fg prose-body-highlight flex items-center justify-center gap-2 px-2 text-center whitespace-nowrap">
{children}
</div>
) : null}
</div>
))}
</div>
</TableCell>
</TableRow>
</TableBody>
)
12 changes: 5 additions & 7 deletions src/features/dashboard/sandbox/events/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
import { useMemo } from 'react'
import type { SandboxEventModel } from '@/core/modules/sandboxes/models'
import {
VirtualizedTableEmptyState,
VirtualizedTableLoaderBody,
VirtualizedTableRow,
} from '@/features/dashboard/common/virtualized-table-ui'
Expand All @@ -21,7 +22,6 @@ import {
Table,
TableBody,
TableCell,
TableEmptyState,
TableHead,
TableHeader,
TableRow,
Expand Down Expand Up @@ -90,12 +90,10 @@ export const SandboxEventsTable = ({
scrollContainer={scrollContainer}
/>
) : (
<TableBody>
<TableEmptyState colSpan={4}>
<HistoryIcon className="size-5" />
No events found
</TableEmptyState>
</TableBody>
<VirtualizedTableEmptyState>
<HistoryIcon className="size-5" />
No events found
</VirtualizedTableEmptyState>
)}
</Table>
)
Expand Down
Loading