Skip to content

Fix proxied landing sitemap and rewrites #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ben-fornefeld wants to merge 2 commits into from
Closed

Fix proxied landing sitemap and rewrites #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f247a94
Fix proxied landing sitemap and rewrites
ben-fornefeld Jun 5, 2026
cb5ca46
Use static sitemap revalidate value
ben-fornefeld Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 1 addition & 43 deletions src/app/(rewrites)/[[...slug]]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import type { NextRequest } from 'next/server'
import { constructSitemap } from '@/app/sitemap'
import { ALLOW_SEO_INDEXING } from '@/configs/flags'
import { ROUTE_REWRITE_CONFIG } from '@/configs/rewrites'
import { BASE_URL } from '@/configs/urls'
import { l, serializeErrorForLog } from '@/core/shared/clients/logger/logger'
import {
Expand All @@ -10,6 +8,7 @@ import {
} from '@/lib/utils/rewrites'

export const dynamic = 'force-static'
export const dynamicParams = true
export const revalidate = 900

const REVALIDATE_TIME = 900 // 15 minutes ttl
Comment thread
ben-fornefeld marked this conversation as resolved.
Expand Down Expand Up @@ -114,44 +113,3 @@ export async function GET(request: NextRequest): Promise<Response> {
)
}
}

export async function generateStaticParams() {
const sitemapEntries = await constructSitemap()

const slugs = sitemapEntries
.filter((entry) => {
const url = new URL(entry.url)
const pathname = url.pathname

// check if this path matches any rule in ROUTE_REWRITE_CONFIG
for (const domainConfig of ROUTE_REWRITE_CONFIG) {
const isIndex = pathname === '/' || pathname === ''
const matchingRule = domainConfig.rules.find((rule) => {
if (isIndex && rule.path === '/') {
return true
}
if (pathname === rule.path || pathname.startsWith(`${rule.path}/`)) {
return true
}
return false
})

if (matchingRule) {
return true
}
}
return false
})
.map((entry) => {
// map the filtered entries to slug format
const url = new URL(entry.url)
const pathname = url.pathname
const pathSegments = pathname
.split('/')
.filter((segment) => segment !== '')

return { slug: pathSegments }
})

return slugs
}
1 change: 1 addition & 0 deletions src/app/sitemap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { DOCUMENTATION_DOMAIN } from '../../next.config.mjs'

// Cache the sitemap for 15 minutes (in seconds)
const SITEMAP_CACHE_TIME = 15 * 60
export const revalidate = 900

/**
* Valid change frequency values for sitemap entries
Expand Down
Loading