feat(ui): migrate icons to e2b shadcn registry#392
Merged
Conversation
Install the e2b icon registry (https://ui.e2b.dev/icons) as the Figma-backed source of truth, replacing the hand-maintained src/ui/primitives/icons.tsx with the generated src/ui/primitives/icons/ directory (barrel + base Icon + per-icon files). - Rewrite all call sites to the new icon names (CheckIcon->CheckmarkIcon, TrashIcon->RemoveIcon, EyeIcon/EyeOffIcon->EyeOpenIcon/EyeClosedIcon, SortAsc/DescIcon->SortUp/DownIcon, LogoutIcon->LogOutIcon, SelectIcon->UpDownIcon, SystemIcon->LaptopIcon, SuccessIcon->CheckCircleIcon). - Map the orphan icons to upstream glyphs (DashboardIcon->GridIcon, FolderUpIcon->FolderUploadIcon, TerminalCustomIcon->TerminalIcon); InvoiceIcon has no upstream equivalent and stays in icons-legacy.tsx.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…utton # Conflicts: # src/features/dashboard/templates/builds/table-cells.tsx
drankou
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the e2b Figma-backed shadcn registry (
https://ui.e2b.dev/icons) the source of truth for icons. Replaces the hand-maintainedsrc/ui/primitives/icons.tsx(121 inline SVGs) with the generatedsrc/ui/primitives/icons/directory (barrel + baseIcon+ per-icon files) and rewrites all ~100 call sites to the new names.What changed
src/ui/primitives/icons/(barrelindex.ts, baseicon.tsx, individual*-icon.tsx).src/ui/primitives/icons.tsx.icons-legacy.tsxfor the one icon with no upstream equivalent.Renamed icons
CheckIconCheckmarkIconTrashIconRemoveIconLogoutIconLogOutIconSortAscIconSortUpIconSortDescIconSortDownIconEyeIconEyeOpenIconEyeOffIconEyeClosedIconSelectIconUpDownIconSystemIconLaptopIconSuccessIconCheckCircleIconOrphan icons (no exact upstream name)
DashboardIconGridIcon(registry)FolderUpIconFolderUploadIcon(registry)TerminalCustomIconTerminalIcon(registry)InvoiceIconicons-legacy.tsxThe registry's base
Icondefaults to 24px (the old set hard-applied 16px). Icons inside buttons/sidebar are explicitly sized and unaffected, but a bare<Icon />with no size class now renders larger — worth a visual pass.Verification
tsc --noEmit→ 0 errors · biome clean · merged latestmain(one icon-import conflict resolved).