Skip to content

Launch Darkly Support for Frontend#408

Merged
matthewlouisbrockman merged 13 commits into
mainfrom
feature-flags-en-979
Jun 13, 2026
Merged

Launch Darkly Support for Frontend#408
matthewlouisbrockman merged 13 commits into
mainfrom
feature-flags-en-979

Conversation

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor

Adds launch darkly support for frontend and a /flags page to check the feature flags (which itself is enabled by feature flag)

@linear-code

linear-code Bot commented Jun 13, 2026

Copy link
Copy Markdown

EN-979

@cla-bot cla-bot Bot added the cla-signed label Jun 13, 2026
@cursor

cursor Bot commented Jun 13, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Introduces an admin-only page that exposes evaluated flag values and team targeting; access depends on LaunchDarkly is_admin with defaults/fallbacks when LD is missing or fails.

Overview
The PR adds @launchdarkly/node-server-sdk, optional LAUNCHDARKLY_SDK_KEY, a server feature-flag service with LD multi-context (user + team), typed FEATURE_FLAGS (is_admin, i_exist), and dashboard/[teamSlug]/flags gated when evaluated isAdmin is true.

Errors / gaps: PR title/description say frontend LaunchDarkly support, but there is no client/browser LD integration—evaluation is server-only. The new flags route is not linked from dashboard navigation, so it is only reachable by URL. i_exist is a test flag still registered in production FEATURE_FLAGS. Access control calls listFeatureFlags (evaluates every flag) and then checks isAdmin from that list instead of a single getBoolean check.

Reviewed by Cursor Bugbot for commit 6f74165. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 13, 2026 1:37am

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de2eaa02fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/server/feature-flags/launchdarkly.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6f74165. Configure here.

Comment thread src/app/dashboard/[teamSlug]/flags/page.tsx
Comment thread src/features/dashboard/flags/feature-flags.tsx
@matthewlouisbrockman matthewlouisbrockman merged commit 8924ffa into main Jun 13, 2026
14 checks passed
@matthewlouisbrockman matthewlouisbrockman deleted the feature-flags-en-979 branch June 13, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants